Moodle

Improve class="accesshide" screen-reader hints in qtype_description.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.1, 2.2
  • Fix Version/s: 2.1.2
  • Component/s: Questions
  • Labels:
    None
  • Testing Instructions:
    Hide

    1. Create a quiz with one Description and one ordinary question.
    2. Preview it, and use firebug to verify that there is a <h3 class="accesshide">Information text</h3> on the description and a <h3 class="accesshide">Question text</h3> on the question.

    Also, run all the unit tests in the question folder, and verify that they pass.

    Show
    1. Create a quiz with one Description and one ordinary question. 2. Preview it, and use firebug to verify that there is a <h3 class="accesshide">Information text</h3> on the description and a <h3 class="accesshide">Question text</h3> on the question. Also, run all the unit tests in the question folder, and verify that they pass.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

All qtypes currently get a <h3 class="accesshide">Question text</h3> at the top of the blue question text bit of the output.

For description 'questions' that should say 'Information text' instead.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Mahmoud, please could you review this for me. Thanks.

Show
Tim Hunt added a comment - Mahmoud, please could you review this for me. Thanks.
Hide
Permalink
Mahmoud Kassaei added a comment -

Well done Tim, that looks fine.

Show
Mahmoud Kassaei added a comment - Well done Tim, that looks fine.
Hide
Permalink
Tim Hunt added a comment -

Thanks Mahmoud. Submitting for integration.

Show
Tim Hunt added a comment - Thanks Mahmoud. Submitting for integration.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Just one tiny-tiny thing, this comment seems inaccurate:

https://github.com/timhunt/moodle/compare/master...MDL-29571#L9R37

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Just one tiny-tiny thing, this comment seems inaccurate: https://github.com/timhunt/moodle/compare/master...MDL-29571#L9R37 Ciao
Hide
Permalink
Tim Hunt added a comment -

Bum! Do you want me to do an amended commit (tomorrow morning); do you want to integrate it anyway with the bad comment; or do you want to wait until next week?

Show
Tim Hunt added a comment - Bum! Do you want me to do an amended commit (tomorrow morning); do you want to integrate it anyway with the bad comment; or do you want to wait until next week?
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

think amend is better, but as you prefer, np here. Thanks!

Show
Eloy Lafuente (stronk7) added a comment - think amend is better, but as you prefer, np here. Thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Going to amend this myself. Tell me how do you feel about that (for --merged stuff in your side and friends).

Also, I requested global perms to amend @ http://tracker.moodle.org/browse/MDL-29520?focusedCommentId=125853&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-125853

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Going to amend this myself. Tell me how do you feel about that (for --merged stuff in your side and friends). Also, I requested global perms to amend @ http://tracker.moodle.org/browse/MDL-29520?focusedCommentId=125853&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-125853 Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (amending comment). Thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated (amending comment). Thanks!
Hide
Permalink
Rossiani Wijaya added a comment -

This is working great.

Test passed.

Show
Rossiani Wijaya added a comment - This is working great. Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

git repositories have been updated with your awesome changes, thanks! Closing.

Show
Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: