Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29619

Resource URL should be properly filtered before generating output

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Resource
    • Labels:
    • Testing Instructions:
      Hide

      1. Add few URL resource to a page
      2. Edit the filed "externalurl" in the table "url" directly from database to contain some invalid urls (for example:- hxxp://something) and/or empty strings.
      3. Try to access those urls from the course page and make sure they generate errors!
      4. Make sure valid urls are displayed normally and there is no regressions.

      Show
      1. Add few URL resource to a page 2. Edit the filed "externalurl" in the table "url" directly from database to contain some invalid urls (for example:- hxxp://something) and/or empty strings. 3. Try to access those urls from the course page and make sure they generate errors! 4. Make sure valid urls are displayed normally and there is no regressions.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      MDL-29619-master

      Description

      Due to the issues as reported in MDL-28483, we might have resource urls with empty and invalid URL in the database.
      When displaying output, this data should be properly filtered and an error must be generated if the URL is invalid or empty.
      At present it simply displays the output page, even if there is an empty url associated with it.

        Attachments

        1. url1.PNG
          url1.PNG
          24 kB
        2. url2.PNG
          url2.PNG
          24 kB

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              ankit_frenz Ankit Agarwal
              Peer reviewer:
              Rossiani Wijaya
              Integrator:
              Aparup Banerjee
              Tester:
              Sam Hemelryk
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                28/Nov/11