Moodle
  1. Moodle
  2. MDL-29640

change the layout of the login page to a better one in formal_white

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Themes
    • Labels:
      None
    • Rank:
      19153

      Description

      with the introduction of the "Remember username" item in the login form in moodlehead/login/index.php
      the page layout (arrangement of fields) in moodlehead/login/index.php in formal_white is no longer fine.
      It would be nice to change it from what I spotted in the first attachment to what is in the second one.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Hi Daniele,

          Sorry but I am sending this back this week - the changes are 100% fine however you already have CSS in code.css (starting line 100) that your new CSS is overriding.
          Really it would be nice to clean up the login page CSS so that we dont' set it in one place and then override it later on in the same theme.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Daniele, Sorry but I am sending this back this week - the changes are 100% fine however you already have CSS in code.css (starting line 100) that your new CSS is overriding. Really it would be nice to clean up the login page CSS so that we dont' set it in one place and then override it later on in the same theme. Cheers Sam
          Hide
          Daniele Cordella added a comment -

          well actually I thought I had to preserve the difference between
          .loginbox .loginform .form-label
          and
          #page-login-index .loginbox .loginform .form-label
          and I was surprised to verify it is useless.

          So... thanks Sam.
          I modified the branch and all is ready again for testing process.

          Show
          Daniele Cordella added a comment - well actually I thought I had to preserve the difference between .loginbox .loginform .form-label and #page-login-index .loginbox .loginform .form-label and I was surprised to verify it is useless. So... thanks Sam. I modified the branch and all is ready again for testing process.
          Hide
          Sam Hemelryk added a comment -

          Thanks Daniele, changes look spot on this time and have been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Daniele, changes look spot on this time and have been integrated now
          Hide
          Rossiani Wijaya added a comment - - edited

          Hmmm. Looking at the patch, its only fixed formal_white themes.

          Should this new layout take place for the rest of themes? The following themes that I tested are still in old arrangement layout: Nimble, Arialist, Binarius, and FormFactor. It might also effected other themes. Maybe should create new issue to fix the rest of the themes.

          Waiting for comment from Sam or Daniele before closing this integration test.

          Show
          Rossiani Wijaya added a comment - - edited Hmmm. Looking at the patch, its only fixed formal_white themes. Should this new layout take place for the rest of themes? The following themes that I tested are still in old arrangement layout: Nimble, Arialist, Binarius, and FormFactor. It might also effected other themes. Maybe should create new issue to fix the rest of the themes. Waiting for comment from Sam or Daniele before closing this integration test.
          Hide
          Daniele Cordella added a comment -

          1. my personal opinion is that this issue should be fixed for each theme, so at canvas or base theme level.
          2. maybe it is better to contact Mary Evans that is looking after a lot of issues on other themes.
          3. regardless to how moodle HQ is going to deal with this issue, please do not stop it too. MDL-29614 and MDL-26760 already have been stopped and they can only wait without our intervention.

          Show
          Daniele Cordella added a comment - 1. my personal opinion is that this issue should be fixed for each theme, so at canvas or base theme level. 2. maybe it is better to contact Mary Evans that is looking after a lot of issues on other themes. 3. regardless to how moodle HQ is going to deal with this issue, please do not stop it too. MDL-29614 and MDL-26760 already have been stopped and they can only wait without our intervention.
          Hide
          Rossiani Wijaya added a comment -

          I created new issue to fix the rest of themes (MDL-29724).

          Therefore, this issue is working great for formal_white.

          Test passed.

          Show
          Rossiani Wijaya added a comment - I created new issue to fix the rest of themes ( MDL-29724 ). Therefore, this issue is working great for formal_white. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: