Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Course completion
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Enable course completion in global settings
      2. Enable course completion in test course
      3. Go to coruse settings > completion tracking and select Completion on unenrolment
      4. Add the course completion block to the page
      5. Visit navigator block->course name->reports->course completion

      Expected result:
      no debug warnings

      Actual result:
      Current code gives two [unenrol]. patched code is ok.

      Show
      1. Enable course completion in global settings 2. Enable course completion in test course 3. Go to coruse settings > completion tracking and select Completion on unenrolment 4. Add the course completion block to the page 5. Visit navigator block->course name->reports->course completion Expected result: no debug warnings Actual result: Current code gives two [unenrol] . patched code is ok.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Rank:
      19162

      Description

      String 'unenrol' is not defined in lang/xx/moodle.php but in lang/xx/enrol.php. Therefore,

       
      --- a/lib/completion/completion_criteria_unenrol.php
      +++ b/lib/completion/completion_criteria_unenrol.php
      @@ -89,7 +89,7 @@ class completion_criteria_unenrol extends completion_criteria {
            * @return  string
            */
           public function get_title() {
      -        return get_string('unenrol');
      +        return get_string('unenrol', 'enrol');
           }
       
           /**
      @@ -107,7 +107,7 @@ class completion_criteria_unenrol extends completion_criteria {
            * @return  string
            */
           public function get_type_title() {
      -        return get_string('unenrol');
      +        return get_string('unenrol', 'enrol');
           }
       
           /**
      

        Activity

        Hide
        Dan Poltawski added a comment -

        Integrators this can be cherry -picked into 2.0 and master

        Show
        Dan Poltawski added a comment - Integrators this can be cherry -picked into 2.0 and master
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sunner Sun added a comment -

        Rebased successfully with latest MOODLE_21_STABLE!

        Show
        Sunner Sun added a comment - Rebased successfully with latest MOODLE_21_STABLE!
        Hide
        Aparup Banerjee added a comment -

        Thanks all, this has been integrated.

        Show
        Aparup Banerjee added a comment - Thanks all, this has been integrated.
        Hide
        Ankit Agarwal added a comment -

        Hi,
        All working fine!
        Test passed!
        Thanks

        Show
        Ankit Agarwal added a comment - Hi, All working fine! Test passed! Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: