Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29656

Bad string id in completion

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Course completion
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Enable course completion in global settings
      2. Enable course completion in test course
      3. Go to coruse settings > completion tracking and select Completion on unenrolment
      4. Add the course completion block to the page
      5. Visit navigator block->course name->reports->course completion

      Expected result:
      no debug warnings

      Actual result:
      Current code gives two [unenrol]. patched code is ok.

      Show
      1. Enable course completion in global settings 2. Enable course completion in test course 3. Go to coruse settings > completion tracking and select Completion on unenrolment 4. Add the course completion block to the page 5. Visit navigator block->course name->reports->course completion Expected result: no debug warnings Actual result: Current code gives two [unenrol] . patched code is ok.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE

      Description

      String 'unenrol' is not defined in lang/xx/moodle.php but in lang/xx/enrol.php. Therefore,

       
      --- a/lib/completion/completion_criteria_unenrol.php
      +++ b/lib/completion/completion_criteria_unenrol.php
      @@ -89,7 +89,7 @@ class completion_criteria_unenrol extends completion_criteria {
            * @return  string
            */
           public function get_title() {
      -        return get_string('unenrol');
      +        return get_string('unenrol', 'enrol');
           }
       
           /**
      @@ -107,7 +107,7 @@ class completion_criteria_unenrol extends completion_criteria {
            * @return  string
            */
           public function get_type_title() {
      -        return get_string('unenrol');
      +        return get_string('unenrol', 'enrol');
           }
       
           /**

        Attachments

          Activity

            People

            Assignee:
            poltawski Dan Poltawski
            Reporter:
            sunner Sunner Sun
            Integrator:
            Aparup Banerjee
            Tester:
            Ankit Agarwal
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/Nov/11