Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29665

auth/db plugin misses user_confirm() method

    Details

    • Testing Instructions:
      Hide
      1. Log in as an administrator and visit <yoursite>/admin/settings.php?section=manageauths.
      2. Ensure the 'Email-based self-registration' plugin is activated and 'Self registration' is set to 'Email-based self-registration'.
      3. Enable the 'External database' plugin.
      4. Click on the settings for the 'External database' and set it up as per http://docs.moodle.org/23/en/External_database_enrolment.
      5. Register an account on your Moodle site, do not click on the link sent by the activation email, we want the user to remain unconfirmed.
      6. As the administrator browse the list of users and choose to edit the newly registered user.
      7. Set the newly registered users authentication method to 'External database'.
      8. Set up an account on the external database for this user.
      9. Ensure you can log in as this user despite your account not being confirmed.
      10. Once logged in check the database and ensure the 'confirm' column in the 'user' table is set to 1 for that user.
      Show
      Log in as an administrator and visit <yoursite>/admin/settings.php?section=manageauths. Ensure the 'Email-based self-registration' plugin is activated and 'Self registration' is set to 'Email-based self-registration'. Enable the 'External database' plugin. Click on the settings for the 'External database' and set it up as per http://docs.moodle.org/23/en/External_database_enrolment . Register an account on your Moodle site, do not click on the link sent by the activation email, we want the user to remain unconfirmed. As the administrator browse the list of users and choose to edit the newly registered user. Set the newly registered users authentication method to 'External database'. Set up an account on the external database for this user. Ensure you can log in as this user despite your account not being confirmed. Once logged in check the database and ensure the 'confirm' column in the 'user' table is set to 1 for that user.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29665_master

      Description

      The auth db plugin does not has the user_confirm() method. This may lead into some problem with special auth flows depending on external db where confirmation is needed, like the auth/manual pluign does. Other standard plugins, depending on external backend such as auth/LDAP, has the methods user_confirm() and can_confirm() as well.

      Solution:
      Add the missing method to auth/db taking it from auth/manual

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: