Moodle
  1. Moodle
  2. MDL-29672

Not consistent breadcrumbs across roles when editing profile

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Navigation
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Please follow the instructions in description and check that the breadcrumbs are now consistent with how you got to the page through the settings block.

      Show
      Please follow the instructions in description and check that the breadcrumbs are now consistent with how you got to the page through the settings block.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      wip-MDL-29672-master

      Description

      In Moodle 2.1.1+ (Build: 20110928)When editing profile, breadcrumbs changes in a non consistent way across users role. To verify and reproduce:

      1. access a Moodle 2.1.1+ (Build: 20110928) with site admin account
      2. click on Settings->My profile settings->Edit profile
      3. breadcrumbs shows Home->My profile settings>Edit profile
      4. now access the user list, select a non-admin user, and "Login as" this user
      5. click on Settings->My profile settings->Edit profile
      6. breadcrumbs shows Home->Site pages, which is not consistent with the breadcrumbs shown to admins.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Hemelryk added a comment -

            Thanks for the report Andrea.

            It's up for peer-review now - problem was two minor things:

            1. Bad call to set_url including a param used for actions
            2. Call to set_course with the site page and missing set_context

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Thanks for the report Andrea. It's up for peer-review now - problem was two minor things: Bad call to set_url including a param used for actions Call to set_course with the site page and missing set_context Cheers Sam
            Hide
            Andrea Bicciolo added a comment -

            Thanks for the quick solution Sam!

            Show
            Andrea Bicciolo added a comment - Thanks for the quick solution Sam!
            Hide
            Sam Hemelryk added a comment -

            Putting up for integration now - I'm 100% confident about these changes.

            Show
            Sam Hemelryk added a comment - Putting up for integration now - I'm 100% confident about these changes.
            Hide
            Aparup Banerjee added a comment -

            Integrated and up for testing across 2.x

            Show
            Aparup Banerjee added a comment - Integrated and up for testing across 2.x
            Hide
            Jason Fowler added a comment -

            Tested with all applicable integration versions. All passed

            Show
            Jason Fowler added a comment - Tested with all applicable integration versions. All passed
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: