-
Bug
-
Resolution: Fixed
-
Major
-
2.0.4, 2.1.1, 2.2
-
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
MOODLE_20_STABLE, MOODLE_21_STABLE
-
Moderate
-
Since some time ago, each time ALL unittests are executed, their execution ends ok but a lot of debugging information is send out about incorrectly nested boxes / containers.
For the records, here it's an excerpt (it's really much, much bigger):
Some HTML tags were opened in the body of the page but not closed.
|
|
Open box at:
|
line 1237 of /lib/outputlib.php: call to xhtml_container_stack->log()
|
line 2226 of /lib/outputrenderers.php: call to xhtml_container_stack->push()
|
line 127 of /admin/tool/unittest/index.php: call to core_renderer->box_start()
|
Close box at:
|
line 1264 of /lib/outputlib.php: call to xhtml_container_stack->log()
|
line 2236 of /lib/outputrenderers.php: call to xhtml_container_stack->pop()
|
line 145 of /admin/tool/unittest/index.php: call to core_renderer->box_end()
|
Open box at:
|
line 1237 of /lib/outputlib.php: call to xhtml_container_stack->log()
|
line 2226 of /lib/outputrenderers.php: call to xhtml_container_stack->push()
|
line 156 of /admin/tool/unittest/index.php: call to core_renderer->box_start()
|
Close box at:
|
line 1264 of /lib/outputlib.php: call to xhtml_container_stack->log()
|
line 2236 of /lib/outputrenderers.php: call to xhtml_container_stack->pop()
|
line 163 of /admin/tool/unittest/index.php: call to core_renderer->box_end()
|
...
|
...
|
...
|
After tracing the execution a lot, it was detected that the culprit of the problem was the moodle_page_test unit test (within lib/simpletest/testpagelib_moodlepage.php), because due to one missing global $PAGE it was unable to restitute the original status of the page, so other tests later (/question ones, also playing with page/output...) were running under an incorrect status.
So this is simply fixed by adding the missing global to moodle_page_test->tearDown(). Doing.
Ciao
- has been marked as being related by
-
MDL-29729 "View Code coverage" link breaks if "code coverage analysis." is halted due to some error
-
- Closed
-