Moodle
  1. Moodle
  2. MDL-29684

meta course sync plugin fixes and improvements

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2, 2.3
    • Fix Version/s: 2.3
    • Component/s: Enrolments
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      1/ enable enrol meta sync
      2/ set up a few links and test every kind of modifications via enrol UI
      3/ edit code and disable propagation of events (add return true; in sync_with_parent_course()) and now try modification via UI followed by CLI sync, again try all combinations of settings and operations
      4/ try cron executes the sync too (once should be enough if somebody reviews the change in version.php)

      Show
      1/ enable enrol meta sync 2/ set up a few links and test every kind of modifications via enrol UI 3/ edit code and disable propagation of events (add return true; in sync_with_parent_course()) and now try modification via UI followed by CLI sync, again try all combinations of settings and operations 4/ try cron executes the sync too (once should be enough if somebody reviews the change in version.php)
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w02_MDL-29684_m23_metaenrol
    • Rank:
      19193

      Description

      People who have roles listed in 'nosyncroleids' are still synchronised in child courses (without any role, but still synchronised).

        Issue Links

          Activity

          Julien Boulen created issue -
          Julien Boulen made changes -
          Field Original Value New Value
          Priority Minor [ 4 ] Major [ 3 ]
          Petr Škoda made changes -
          Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-30156 [ MDL-30156 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-29043 [ MDL-29043 ]
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w51_MDL-29684_m23_metaenrol
          Pull Master Branch w51_MDL-29684_m23_metaenrol
          Pull from Repository git://github.com/skodak/moodle.git
          Fix Version/s 2.2.1 [ 11456 ]
          Fix Version/s 2.3 [ 10657 ]
          Testing Instructions Here, a discussion which explain full steps : http://moodle.org/mod/forum/discuss.php?d=168701 1/ enable enrol meta sync
          2/ set up a few links and test every kind of modifications via enrol UI
          3/ edit code and disable propagation of events (add return true; in sync_with_parent_course()) and now try modification via UI followed by CLI sync, again try all combinations of settings and operations
          4/ try cron executes the sync too (once should be enough if somebody reviews the change in version.php)
          Pull 2.2 Diff URL https://github.com/skodak/moodle/compare/MOODLE_22_STABLE...w51_MDL-29684_m22_metaenrol
          Pull 2.2 Branch w51_MDL-29684_m22_metaenrol
          Petr Škoda made changes -
          Link This issue is blocked by MDL-30789 [ MDL-30789 ]
          Petr Škoda made changes -
          Link This issue is blocked by MDL-30789 [ MDL-30789 ]
          Petr Škoda made changes -
          Status Waiting for integration review [ 10010 ] Reopened [ 4 ]
          Petr Škoda made changes -
          Status Reopened [ 4 ] Development in progress [ 3 ]
          Petr Škoda made changes -
          Link This issue has been marked as being related by MDL-30509 [ MDL-30509 ]
          Petr Škoda made changes -
          Summary meta course: nosyncroleids doesn't work meta course sync plugin fixes and improvements
          Petr Škoda made changes -
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Petr Škoda made changes -
          Link This issue is blocked by MDL-30945 [ MDL-30945 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for integration review [ 10010 ]
          Sam Hemelryk made changes -
          Integrator samhemelryk stronk7
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.2.2 [ 11552 ]
          Fix Version/s 2.2.1 [ 11456 ]
          Petr Škoda made changes -
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.3 [ 10657 ]
          Fix Version/s 2.2 [ 10656 ]
          Fix Version/s 2.1 [ 10370 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.1 [ 10370 ]
          Fix Version/s 2.2 [ 10656 ]
          Affects Version/s 2.2 [ 10656 ]
          Affects Version/s 2.1 [ 10370 ]
          Sam Hemelryk made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester samhemelryk
          Sam Hemelryk made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 12/Jan/12
          Dan Marsden made changes -
          Link This issue is a clone of MDL-31374 [ MDL-31374 ]
          Petr Škoda made changes -
          Link This issue is duplicated by MDL-31705 [ MDL-31705 ]

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: