Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29686

yui_combo returns 304 HTTP header even when it is asked for a module with revision -1

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.3
    • Component/s: JavaScript, Libraries
    • Labels:
    • Testing Instructions:
      Hide

      For developers:
      1/ disable js caching
      2/ edit some yui module fine in some moodle component (alert('grrr')
      3/ verify the modification is laoded automatically
      4/ enable caching
      5/ undo modification
      6/ verify the cached modified version is returned
      7/ reset caches
      8/ verify the original unmodified file is returned

      Show
      For developers: 1/ disable js caching 2/ edit some yui module fine in some moodle component (alert('grrr') 3/ verify the modification is laoded automatically 4/ enable caching 5/ undo modification 6/ verify the cached modified version is returned 7/ reset caches 8/ verify the original unmodified file is returned
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w40_MDL-29686_m2_yuicaching

      Description

      Steps to reproduce:
      ===================

      1. make sure you have $CFG->cachejs = false;
      2. enable firebug or other favourite toy and watch requests for JS files via /theme/yui_combo.php
      3. locate a request that asks for a module with -1 revision like "http://your.url/moodle/theme/yui_combo.php?3.2.0/...blahblah...js&moodle/-1/block_navigation/navigation

      Expected result:
      ================

      As the block_navigation YUI module has revision -1 (thanks to cachejs = false), it should be reloaded and firebug should report result header "200 OK" with the reloaded content.

      What actually happens:
      ======================

      The script returns "304 Not Modified" header even when the module was modified. Hard reload must be performed.

        Attachments

          Activity

            People

            • Assignee:
              skodak Petr Skoda
              Reporter:
              mudrd8mz David Mudrák (@mudrd8mz)
              Integrator:
              Sam Hemelryk
              Tester:
              Sam Hemelryk
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Ryan Wyllie, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                28/Nov/11