Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29692

Wrong default role in cohort enrol in Chrome

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.1.1, 2.2
          • Fix Version/s: 2.1.3
          • Component/s: Enrolments
          • Labels:
            None
          • Database:
            PostgreSQL
          • Testing Instructions:
            Hide

            1. Ensure that default role for cohort enrolment plugin is set to Student (Home ► Site administration ► Plugins ► Enrolments ► Cohort sync) and clear the caches.
            2. Open the course and choose Users > Enrolled Users
            3. Click on the "Enrol Cohort" button
            4. Check that the role is set to default one (i.e. Student, not Manager).
            5. Repeat steps 2-4 for different browsers.

            Show
            1. Ensure that default role for cohort enrolment plugin is set to Student (Home ► Site administration ► Plugins ► Enrolments ► Cohort sync) and clear the caches. 2. Open the course and choose Users > Enrolled Users 3. Click on the "Enrol Cohort" button 4. Check that the role is set to default one (i.e. Student, not Manager). 5. Repeat steps 2-4 for different browsers.
          • Affected Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE
          • Pull from Repository:

            Description

            While the fix introduced in MDL-24280 works perfectly for all browsers in 2.0, it does not work for Chrome in 2.1. The attached patch fixes the problem. it has been verified with IE and Gecko (Iceweasel, FF).

              Gliffy Diagrams

                Attachments

                  Issue Links

                  is duplicated by

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-27425 bad default role in "Enrol cohort" ajax dialog in Chrome

                  • Minor - Minor loss of function where workaround is possible
                  • Closed
                  will help resolve

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-24280 Default role when "enrol cohort" is Manager instead of Student

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    kabalin Ruslan Kabalin added a comment -

                    The fix can be cleanly cherry-picked to master.

                    Show
                    kabalin Ruslan Kabalin added a comment - The fix can be cleanly cherry-picked to master.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks Ruslan, this has been integrated now. Merged to 21 and cherry-picked to master.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks Ruslan, this has been integrated now. Merged to 21 and cherry-picked to master.
                    Hide
                    Permalink
                    nebgor Aparup Banerjee added a comment -

                    yup - shows learner as default. (ff,chrome,ie8)

                    Show
                    nebgor Aparup Banerjee added a comment - yup - shows learner as default. (ff,chrome,ie8)
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

                    Closing, ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        1 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          28/Nov/11