Moodle
  1. Moodle
  2. MDL-29692

Wrong default role in cohort enrol in Chrome

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.2
    • Fix Version/s: 2.1.3
    • Component/s: Enrolments
    • Labels:
      None
    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      1. Ensure that default role for cohort enrolment plugin is set to Student (Home ► Site administration ► Plugins ► Enrolments ► Cohort sync) and clear the caches.
      2. Open the course and choose Users > Enrolled Users
      3. Click on the "Enrol Cohort" button
      4. Check that the role is set to default one (i.e. Student, not Manager).
      5. Repeat steps 2-4 for different browsers.

      Show
      1. Ensure that default role for cohort enrolment plugin is set to Student (Home ► Site administration ► Plugins ► Enrolments ► Cohort sync) and clear the caches. 2. Open the course and choose Users > Enrolled Users 3. Click on the "Enrol Cohort" button 4. Check that the role is set to default one (i.e. Student, not Manager). 5. Repeat steps 2-4 for different browsers.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      19202

      Description

      While the fix introduced in MDL-24280 works perfectly for all browsers in 2.0, it does not work for Chrome in 2.1. The attached patch fixes the problem. it has been verified with IE and Gecko (Iceweasel, FF).

        Issue Links

          Activity

          Hide
          Ruslan Kabalin added a comment -

          The fix can be cleanly cherry-picked to master.

          Show
          Ruslan Kabalin added a comment - The fix can be cleanly cherry-picked to master.
          Hide
          Sam Hemelryk added a comment -

          Thanks Ruslan, this has been integrated now. Merged to 21 and cherry-picked to master.

          Show
          Sam Hemelryk added a comment - Thanks Ruslan, this has been integrated now. Merged to 21 and cherry-picked to master.
          Hide
          Aparup Banerjee added a comment -

          yup - shows learner as default. (ff,chrome,ie8)

          Show
          Aparup Banerjee added a comment - yup - shows learner as default. (ff,chrome,ie8)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: