Moodle
  1. Moodle
  2. MDL-29698

Clicking the "revert to draft" button in the assignment module grading interface results in broken log entries

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.1, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Environment:
      Windows Server 2003
      PHP 5.3.6
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      This requires two users a teacher and a student

      1. As a teacher Create an Assignment using the Advanced uploading of files type. Be sure to set the "Enable send for marking button" option to "yes"
      2. As a student upload a single file to the assignment activity.
      3. As the student click the "Send for marking" button.
      4. On the confirmation screen click the continue button

      5. As the teacher browse to the assignment activity and click on the "View 1 submitted assignments" link
      6. Click on the Grade link to view the student submission (in the status column of the table)
      7. Click the "Revert to draft button"
      8. Browse to the teachers activity report in the navigation block (My Courses -> Course name -> Participants -> Teacher Name -> Activity Reports -> All Logs)
      9. Locate the "Assignment view submission" log entry (Should be the second entry from the top. and click the "Assignment view submission" link

      Verify that the student submission is shown

      Show
      This requires two users a teacher and a student 1. As a teacher Create an Assignment using the Advanced uploading of files type. Be sure to set the "Enable send for marking button" option to "yes" 2. As a student upload a single file to the assignment activity. 3. As the student click the "Send for marking" button. 4. On the confirmation screen click the continue button 5. As the teacher browse to the assignment activity and click on the "View 1 submitted assignments" link 6. Click on the Grade link to view the student submission (in the status column of the table) 7. Click the "Revert to draft button" 8. Browse to the teachers activity report in the navigation block (My Courses -> Course name -> Participants -> Teacher Name -> Activity Reports -> All Logs) 9. Locate the "Assignment view submission" log entry (Should be the second entry from the top. and click the "Assignment view submission" link Verify that the student submission is shown
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      19208

      Description

      Clicking the "revert to draft" button on the grading screen of the advanced upload assignment type results in a broken log entry.

      Steps to reproduce:
      This requires two users a teacher and a student

      1. As a teacher Create an Assignment using the Advanced uploading of files type. Be sure to set the "Enable send for marking button" option to "yes"
      2. As a student upload a single file to the assignment activity.
      3. As the student click the "Send for marking" button.
      4. On the confirmation screen click the continue button

      5. As the teacher browse to the assignment activity and click on the "View 1 submitted assignments" link
      6. Click on the Grade link to view the student submission (in the status column of the table)
      7. Click the "Revert to draft button"
      8. Browse to the teachers activity report in the navigation block (My Courses -> Course name -> Participants -> Teacher Name -> Activity Reports -> All Logs)
      9. Locate the "Assignment view submission" log entry (Should be the second entry from the top. and click the "Assignment view submission" link

      Expected result:
      You will be brought to that students assignment submission

      Actual result:
      Error: Invalid course module ID

      7.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Hi Stephen,
          The changes look good thanks - I've put this up for integration review for you now.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Stephen, The changes look good thanks - I've put this up for integration review for you now. Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I've created MDL-29799 about how this (and other) log entries are handled by backup & restore. It seems we are missing some there.

          In the other side, I've integrated this in 20, 21 and master (by cherry-picking). Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - I've created MDL-29799 about how this (and other) log entries are handled by backup & restore. It seems we are missing some there. In the other side, I've integrated this in 20, 21 and master (by cherry-picking). Thanks!
          Hide
          Sam Hemelryk added a comment -

          Thanks guys - this has passed testing

          Show
          Sam Hemelryk added a comment - Thanks guys - this has passed testing
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for all the hard work. This is now part of Moodle, your favorite LMS.

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for all the hard work. This is now part of Moodle, your favorite LMS. Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: