[MDL-29701] mform disableif doesn't work on 'editor' element when wysiwig enabled - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0, 2.6.5, 2.8.7, 2.9.1, 3.4.4, 3.5.1
Fix Version/s: 3.4.5, 3.5.2
Component/s: Forms Library, HTML Editor (Atto)
Labels:
- ci
- patch
- triaged

Testing Instructions:
Hide

Copy the attached testform.php to your installation

Login to Moodle

Open editor preferences and set editor to Atto

Open http://path/to/your/moodle/testform.php on your site

Toggle the checkbox a few times

Confirm that the editor is enabled, and disabled as you would expect (unchecked = enabled, checked = disabled)

Repeat for TinyMCE

Repeat for Plain text editor
Show
Copy the attached testform.php to your installation Login to Moodle Open editor preferences and set editor to Atto Open http://path/to/your/moodle/testform.php on your site Toggle the checkbox a few times Confirm that the editor is enabled, and disabled as you would expect (unchecked = enabled, checked = disabled) Repeat for TinyMCE Repeat for Plain text editor
Affected Branches:
MOODLE_20_STABLE, MOODLE_26_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/phuchau1509/moodle
Pull 3.5 Branch:
~~MDL-29701~~-35
Pull 3.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_35_STABLE...phuchau1509:MDL-29701-35
Pull Master Branch:
~~MDL-29701~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...phuchau1509:MDL-29701-master

Description

If you have a field that uses htmleditor and the user allows wysiwigs - the disableif check doesn't work - if they elect to use standard web forms in their profile - it works as expected.

I can take a look at this - just might need some pointers on where/how to go about fixing it.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-29701_AttoEditor.PNG
15 kB
25/Jul/18 9:58 PM
MDL-29701_PlainTextEditor.PNG
11 kB
25/Jul/18 9:58 PM
MDL-29701_TinyMCE.PNG
17 kB
25/Jul/18 9:58 PM
test1.PNG
38 kB
18/Jul/18 5:44 AM
test2.PNG
36 kB
18/Jul/18 5:44 AM
testform.php
0.6 kB
16/Jul/18 8:30 PM

Issue Links

has a non-specific relationship to

MDL-29421 Form elements editor and filepicker do not support freezing

Open

will be (partly) resolved by

MDL-58519 MoodleQuickForm_editor::getValue() is not compatible with MoodleQuickForm::exportValues() logic

Closed

Activity

People

Assignee:: Jake Hau

Reporter:: Dan Marsden

Peer reviewer:: Tim Hunt

Integrator:: Andrew Nicols

Tester:: Anna Carissa Sadia

Participants:: Andrew Nicols, Anna Carissa Sadia, CiBoT, Dan Marsden, Eloy Lafuente (stronk7), Hieu Vu, Jake Dallimore, Jake Hau, Marina Glancy, Pau Ferrer, Peter Spicer, Tim Hunt

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 8 Vote for this issue

Watchers:: 16 Start watching this issue

Dates

Created:: 08/Oct/11 6:15 PM

Updated:: 13/Sep/18 7:39 AM

Resolved:: 27/Jul/18 2:10 PM

Fix Release Date:: 10/Sep/18

Time Tracking

Estimated:

Remaining:

Logged:

30m