Moodle

Guest enrol instance can not be default added to request & approving courses

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.5, 2.1.2, 2.2
  • Fix Version/s: 2.0.6, 2.1.3
  • Component/s: Enrolments
  • Labels:
    None
  • Testing Instructions:
    Hide

    1 $CFG->enablecourserequests = true;
    2 request a course through /course/request.php
    3 approve it in /course/pending.php
    4 Check whether the guest enrol instance is added to created course
    4.1 CURRENT: no
    4.2 PATCHED: yes

    Show
    1 $CFG->enablecourserequests = true; 2 request a course through /course/request.php 3 approve it in /course/pending.php 4 Check whether the guest enrol instance is added to created course 4.1 CURRENT: no 4.2 PATCHED: yes
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Pull from Repository:

Description

Guest enrol has a global setting, defaultenrol, which will add a guest enrol instance to any new courses.

This is true when the course is created manually by course creator. But for the requested courses, after being approved, they will not get the instance automatically.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Poltawski added a comment -

Verified the problem and the fix.

This can be cherry-picked onto master and 20_STABLE

Show
Dan Poltawski added a comment - Verified the problem and the fix. This can be cherry-picked onto master and 20_STABLE
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sunner Sun added a comment -

Rebased successfully with latest MOODLE_21_STABLE!

Show
Sunner Sun added a comment - Rebased successfully with latest MOODLE_21_STABLE!
Hide
Permalink
Aparup Banerjee added a comment -

O.o hm, nice catch thanks for the report and fix.

Its been cherry picked into master, 21 and 20 stable and is up for testing.

Show
Aparup Banerjee added a comment - O.o hm, nice catch thanks for the report and fix. Its been cherry picked into master, 21 and 20 stable and is up for testing.
Hide
Permalink
Jason Fowler added a comment -

All works as described

Show
Jason Fowler added a comment - All works as described
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: