Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29722

Guest enrol instance can not be default added to request & approving courses

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Enrolments
    • Labels:
      None
    • Testing Instructions:
      Hide

      1 $CFG->enablecourserequests = true;
      2 request a course through /course/request.php
      3 approve it in /course/pending.php
      4 Check whether the guest enrol instance is added to created course
      4.1 CURRENT: no
      4.2 PATCHED: yes

      Show
      1 $CFG->enablecourserequests = true; 2 request a course through /course/request.php 3 approve it in /course/pending.php 4 Check whether the guest enrol instance is added to created course 4.1 CURRENT: no 4.2 PATCHED: yes
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE

      Description

      Guest enrol has a global setting, defaultenrol, which will add a guest enrol instance to any new courses.

      This is true when the course is created manually by course creator. But for the requested courses, after being approved, they will not get the instance automatically.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            poltawski Dan Poltawski added a comment -

            Verified the problem and the fix.

            This can be cherry-picked onto master and 20_STABLE

            Show
            poltawski Dan Poltawski added a comment - Verified the problem and the fix. This can be cherry-picked onto master and 20_STABLE
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            sunner Sunner Sun added a comment -

            Rebased successfully with latest MOODLE_21_STABLE!

            Show
            sunner Sunner Sun added a comment - Rebased successfully with latest MOODLE_21_STABLE!
            Hide
            nebgor Aparup Banerjee added a comment -

            O.o hm, nice catch thanks for the report and fix.

            Its been cherry picked into master, 21 and 20 stable and is up for testing.

            Show
            nebgor Aparup Banerjee added a comment - O.o hm, nice catch thanks for the report and fix. Its been cherry picked into master, 21 and 20 stable and is up for testing.
            Hide
            phalacee Jason Fowler added a comment -

            All works as described

            Show
            phalacee Jason Fowler added a comment - All works as described
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11