Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29738

Remove unused stylesheet hook

    XMLWordPrintable

    Details

      Description

      We originally wanted to apply our stylesheets to all HTML content and did so via use of the $CFG->stylesheets variable, and manipulating the content of stored files as they served.

      However, the section of the code fetching the stylesheets was commented out in 2009 (MDL-20204), and the $ufo code was removed back in 2014 (MDL-36669).
      Since then this code has just been wasting cycles by performing totally unnecessary preg_match and preg_replace calls on all HTML content as it is served.

      This issue was originally about fixing that code, but is now about removing it.
      Most places where we did this in Moodle have been templatised (e.g. all outbound e-mails).

      Original description follows

      The forum module sends copy of discussion topics to people who has subscribed the forum. The mail sent is an html page. In this page the head section is empty, so no css link is reported. Subscribers receive text and images, but don't receive neither box nor font information nor colors nor any style information.

      I checked the problem subscribing a forum of moodle.org: I received only text without any css information.

      Add the style information manually in the discussion topic html doesn't solve the problem: they are automatically deleted by moodle.

      (Edited to add description provided by Luciano in a later comment.)

      http://moodle.org/mod/forum/discuss.php?d=187579
      http://tracker.moodle.org/browse/MDL-29152

      see MDL-21120 too.

      SAME AS CLOSED 29152 - OPENED BECAUSE OF SUGGESTION OF MAUNO KOPERLAINEN
      http://moodle.org/mod/forum/discuss.php?d=187581

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              luciano Luciano Biondo
              Peer reviewer:
              Mark Nelson Mark Nelson
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Ryan Wyllie Ryan Wyllie
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              8 Vote for this issue
              Watchers:
              11 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Jul/16