Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1, 2.3.6, 2.4, 2.5
-
Component/s: Questions
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
Fixed Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Pull from Repository:
-
Pull 2.4 Branch:
MDL-29758_24 -
Pull 2.4 Diff URL:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
Mode = adaptive mode
Question text=
Q01.- {1:SHORTANSWER:=correct answer}
Q02.- {1:SHORTANSWER:=correct answer}
Q03.- {1:SHORTANSWER:=correct answer}
Q04.- {1:SHORTANSWER:=correct answer~%50%half correct answer}
Screenshot #1 compares the 1.9 and 2.1 displays of a Cloze question, in adaptive mode, when Submit page (1.9) or Check (2.1) button is clicked.
- the 1.9 version clearly shows by using colors and icons which sub-questions were correctly, incorrectly or partially correctly answered and - by not using any coloring or icons - the sub-question which was left un-answered. Hovering over the questions does not provide any info.
- 2.1, on the other hand, does not display such information ; the only info available is obtained by hovering over the sub-questions, which is not so immediately visible to the student.
Screenshot #2 compares the 1.9 and 2.1 displays of a Cloze question, in adaptive mode, when Submit all and finish button is clicked.
- the 1.9 version uses colors and ticks to display information about the correctness of the answers. Note that Q03 is left white, since it was un-answered, which is OK. HOvering over the sub-question answer boxes provides info re the "correct answer".
- the 2.1 version also displays colors and ticks. But it wrongly displays Q03 in red; that un-answered sub-question should be displayed in white. [BUG]
Hovering over the sub-questions answer boxes provides interesting information. Unfortunately, Q02 tooltip shows "Not answered" where it should be "Incorrect". [BUG]
Bugs to be fixed are marked [BUG] in above Description text.
Improvements requested:
- When checking his answers, in 2.1 the student should see the correctness/incorrectness of his answers clearly marked (color and icon) as it was in 1.9. (Screenshot #1) and as it is when Submitting all in 2.1 (Screenshot #2). This is quite indispensable in Adaptive mode, especially for Cloze questions containing a large number of SA sub-questions.
- When hovering over the textbox of a sub-question that has not yet been answered, no "Mark 0 out of 1" should be displayed.
Issue Links
- will help resolve
-
MDL-35273
Cloze question does not show "Whether correct", "Specific feedback", "General feedback" and "Right Answer" on Interative and Adaptative question behaviours
-
Activity
I agree with Jean-Michel's comments dated 22/Apr/13 2:20 PM.
I would be grateful if Jean-Michel would turn Tim's suggested changes in the Quiz forum into a git commit and write the relevant test units (at which J.-M. is very good 
).
Thanks Joseph but don't forget we are both french so I learned "Le corbeau et le renard" when I was a schoolboy 
Turning Tim's change in a github branch is quite easy.
Question for Tim:
For the tests, I assume we only want to test that the classes are present in the output, so something like
question_pattern_expectation('~<input[^>]* class="correct" [^>]*/>~')
and
question_pattern_expectation('~<input[^>]* class="incorrect" [^>]*/>~')
would be enough ? or do we want to test that each subquestion has the right class associated ?
Oops, I realize my wait to use assertTag with a regexp is flawed in some case because incorrect and partiallycorrect both contains correct as a substring 
Splendid so I used the new way of doing things and not the deprecated one
Additionally working on this gave you the occasion to say to somebody else what is the recommended way
If you can tell me if my test are OK, I will continue working on this in the evening. I have some gardening to do for now.
Oops, I only saw your message "I guess in the qtype is slightly better" after doing it in the behaviour, but as you don't mind ...
Tested on the 2.3, 2.4 and master integration branches.
The adaptive mode now shows colour highlighting.
Test passed. 
Did you think this day was not going to arrive ever?
Your patience has been rewarded, yay, sent upstream, thanks!
Closing...ciao
"When checking his answers, in 2.1 the student should see the correctness/incorrectness of his answers clearly marked (color and icon) as it was in 1.9"
I do agree... In adaptative mode, it's quite useful for students to be able to see quickly and easily what is rigth and what is wrong.
No news about this improvement ?