Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29768

debugstringids option does nothing

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Language
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Go to admin debugging page
      2. Turn on the 'debugstringids' option
      3. Request any page with the parameter 'strings=1' added to the URL, such as /course/?strings=1

      • Verify that string identifiers in the form {id/component}

        appear (component will be blank for moodle.php strings).
        4. Request any page without the strings=1 parameter, such as /course/

      • Verify that string IDs do not appear.
        5. On the admin debugging page, turn the option off again.
        6. Request any page with the parameter 'strings=1' added to the URL, such as /course/?strings=1
      • Verify that string IDs do not appear.
      Show
      1. Go to admin debugging page 2. Turn on the 'debugstringids' option 3. Request any page with the parameter 'strings=1' added to the URL, such as /course/?strings=1 Verify that string identifiers in the form {id/component} appear (component will be blank for moodle.php strings). 4. Request any page without the strings=1 parameter, such as /course/ Verify that string IDs do not appear. 5. On the admin debugging page, turn the option off again. 6. Request any page with the parameter 'strings=1' added to the URL, such as /course/?strings=1 Verify that string IDs do not appear.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29768-master

      Description

      On debugging admin page there is a 'debugstringids' option. Contrary to the description, this does nothing and is not referenced in any code.

      Even if it worked it is not very useful as often we can't turn it on for a whole server. I am reimplementing it for Moodle 2.2 with the requirement to use '&strings=1' in the URL to trigger it (i.e. turning on the debug option does nothing on its own, you also need to put that parameter in). This means it can be left on by default on test servers.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              quen Sam Marshall added a comment -

              Note: I changed the name of the description lang string because this needs to be retranslated to include information about the parameter. Also uses the new naming convention as a bonus.

              Show
              quen Sam Marshall added a comment - Note: I changed the name of the description lang string because this needs to be retranslated to include information about the parameter. Also uses the new naming convention as a bonus.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated thanks!

              1) I've added extra commit modifying admin/settings/development.php to use the new string
              2) Yay! We have ONE string there using the new key style.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated thanks! 1) I've added extra commit modifying admin/settings/development.php to use the new string 2) Yay! We have ONE string there using the new key style.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Passing this now thanks guys. Two things I think would be good improvements (albeit I don't know if everyone would agree).

              1. If $component is empty display `moodle` (for consistency)
              2. Wrap the {foo/bar}

                in a tag with a CSS class - perhaps <em> so that a) it is easy to visibly identify without styles and b) themer's can do whatever with it.

              Anyway just ideas.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Passing this now thanks guys. Two things I think would be good improvements (albeit I don't know if everyone would agree). If $component is empty display `moodle` (for consistency) Wrap the {foo/bar} in a tag with a CSS class - perhaps <em> so that a) it is easy to visibly identify without styles and b) themer's can do whatever with it. Anyway just ideas. Cheers Sam
              Hide
              nebgor Aparup Banerjee added a comment - - edited

              i'm getting this on a fresh installation (while running installation):
              Notice: Undefined property: stdClass::$debugstringids in /home/aparup/mcode/integration/lib/moodlelib.php on line 6737 Notice: Undefined property: stdClass::$debugstringids in /home/aparup/mcode/integration/lib/moodlelib.php on line 6737 Notice: Undefined property: stdClass::$debugstringids in /home/aparup/mcode/integration/lib/moodlelib.php on line 6737

              Show
              nebgor Aparup Banerjee added a comment - - edited i'm getting this on a fresh installation (while running installation): Notice: Undefined property: stdClass::$debugstringids in /home/aparup/mcode/integration/lib/moodlelib.php on line 6737 Notice: Undefined property: stdClass::$debugstringids in /home/aparup/mcode/integration/lib/moodlelib.php on line 6737 Notice: Undefined property: stdClass::$debugstringids in /home/aparup/mcode/integration/lib/moodlelib.php on line 6737
              Hide
              nebgor Aparup Banerjee added a comment -

              i've added a quick fix to this into integration master : 77c3e9d0c63524ce8e614d6edf63c44a2a8ce349

              Show
              nebgor Aparup Banerjee added a comment - i've added a quick fix to this into integration master : 77c3e9d0c63524ce8e614d6edf63c44a2a8ce349
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Sam: I've created MDL-29816 to continue with those improvements.
              Apu: Well spotted, while I caught the same thing in another issue this week, I missed this one completely. Thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Sam: I've created MDL-29816 to continue with those improvements. Apu: Well spotted, while I caught the same thing in another issue this week, I missed this one completely. Thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Many thanks for all the hard work. This is now part of Moodle, your favorite LMS.

              Closing as fixed, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for all the hard work. This is now part of Moodle, your favorite LMS. Closing as fixed, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/11