Moodle
  1. Moodle
  2. MDL-29778

disclosure triangle is not completely visible (SOLUTION INCLUDED)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Go to Settings -> Site administration -> Users -> Permissions -> Site administrator
      and look at the disclosure triangle.
      It should be completely visible.

      Show
      Go to Settings -> Site administration -> Users -> Permissions -> Site administrator and look at the disclosure triangle. It should be completely visible.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19292

      Description

      Go to Settings -> Site administration -> Users -> Permissions -> Site administrator
      with the standard theme.

      You will find the disclosure triangle below the "search" field in the column of "Current site administrators"
      cutted as you can see in the attachment.
      THIS IS TRUE in arialist, formal_white, formfactor, fusion, leatherbound, nimble, nonzero, overlay, serenity, sky_high, splash AND EVEN STANDARD.

      Because of this, my proposal is to intervene at the central level changing
      canvas/style/admin.css selector at line 69

      from

      #userselector_options {
      	font-size: 0.75em;
      }

      to

      #userselector_options {
      	font-size: 0.75em;
          padding: 0.3em;
      }

      and in
      standard/style/core.css at line 198

      from

      #userselector_options {font-size: 0.75em;}

      to

      #userselector_options {font-size: 0.75em;padding: 0.3em;}

        Activity

        Hide
        Daniele Cordella added a comment -

        This attachment just to improve my poor description of the issue

        Show
        Daniele Cordella added a comment - This attachment just to improve my poor description of the issue
        Hide
        Daniele Cordella added a comment -

        This is how the disclosure triangle is supposed to be

        Show
        Daniele Cordella added a comment - This is how the disclosure triangle is supposed to be
        Hide
        Mary Evans added a comment - - edited

        Hi Danielle,

        This works best if the change is made only to theme/style/base/user.css

        @Line 42
        #userselector_options {padding: 0.3em 0;}
        

        Thanks
        Mary

        Show
        Mary Evans added a comment - - edited Hi Danielle, This works best if the change is made only to theme/style/base/user.css @Line 42 #userselector_options {padding: 0.3em 0;} Thanks Mary
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Mary this has been integrated now
        Hide
        Sam Hemelryk added a comment -

        Tested during integration and passed

        Show
        Sam Hemelryk added a comment - Tested during integration and passed
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: