Moodle
  1. Moodle
  2. MDL-29781

Overlay theme FIX for side-post-only layout

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Before selecting Overlay in Theme Selector make sure ALL blocks are on the right-hand side (side-post).
      2. Select Overlay theme in normal way taking particular note of the SCREENSHOT of what the theme should look like when side-pre is visible.
      3. Once selected CHECK page layout, especially "Side Post ONLY". Is it consistent throughout, including when side blocks are docked?
      4. Now enable EDITING and attempt to MOVE a block or two. You should be able to move a block from SIDE-POST (right) to SIDE-PRE (left).
      5. With blocks in position (left and right) disable editing, and test for consistency, when docking Side-Pre (left) and then Side-Post (right). Normally when all blocks from Side-Pre have been docked the page reverts to a side-post-only layout. This is true also when Side-Pre is still in place and Side-Post is docked.

      Show
      1. Before selecting Overlay in Theme Selector make sure ALL blocks are on the right-hand side (side-post). 2. Select Overlay theme in normal way taking particular note of the SCREENSHOT of what the theme should look like when side-pre is visible. 3. Once selected CHECK page layout, especially "Side Post ONLY". Is it consistent throughout, including when side blocks are docked? 4. Now enable EDITING and attempt to MOVE a block or two. You should be able to move a block from SIDE-POST (right) to SIDE-PRE (left). 5. With blocks in position (left and right) disable editing, and test for consistency, when docking Side-Pre (left) and then Side-Post (right). Normally when all blocks from Side-Pre have been docked the page reverts to a side-post-only layout. This is true also when Side-Pre is still in place and Side-Post is docked.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
    • Rank:
      19294

      Description

      Layout issues on BLOG STYLE CORE themes (Nonzero, Ovelay, Sky High) have needed fixing. Overlay is the last of these themes.

        Issue Links

          Activity

          Hide
          Dietmar Wagner added a comment -

          Hi Mary,
          just seen this new MDL issue.
          I've testes our improved overlay during the last two days. I think you can give it a "GO".
          Tell me if can do anything.

          Cheers Dietmar
          Dietmar

          Thanks for mentioning my name in the sky_high thread. I really enjoyed our "joint venture".

          Show
          Dietmar Wagner added a comment - Hi Mary, just seen this new MDL issue. I've testes our improved overlay during the last two days. I think you can give it a "GO". Tell me if can do anything. Cheers Dietmar Dietmar Thanks for mentioning my name in the sky_high thread. I really enjoyed our "joint venture".
          Hide
          Mary Evans added a comment -

          Hi Dietmar,

          As you will see I have just finished this and submitted it for integration. I had a few problems which I have sorted out now. I noticed some strange behaviour though when MOVING an RSS Feed Block and also a Comments Block, both instances broke the menu display completely in the time it took each individual block to move from side-post to side-pre, but once in place the menu returned to normal. I am guessing there is some conflict with AJAX/JavaScript somewhere??? Or it is my WAMP server!

          As for giving you the credit...well I would never have found the solution without your help and guidance. Indeed you have been a great help to me over the last 18 months or so. I did not realise how sensitive this particular layout was going to be, especially with regards the importance you stressed in putting the full path to the CSS selector so that the CSS rule worked.

          I too enjoyed this joint venture.
          Many thanks

          Mary

          Show
          Mary Evans added a comment - Hi Dietmar, As you will see I have just finished this and submitted it for integration. I had a few problems which I have sorted out now. I noticed some strange behaviour though when MOVING an RSS Feed Block and also a Comments Block, both instances broke the menu display completely in the time it took each individual block to move from side-post to side-pre, but once in place the menu returned to normal. I am guessing there is some conflict with AJAX/JavaScript somewhere??? Or it is my WAMP server! As for giving you the credit...well I would never have found the solution without your help and guidance. Indeed you have been a great help to me over the last 18 months or so. I did not realise how sensitive this particular layout was going to be, especially with regards the importance you stressed in putting the full path to the CSS selector so that the CSS rule worked. I too enjoyed this joint venture. Many thanks Mary
          Hide
          Sam Hemelryk added a comment -

          Fixed up the diff URL's and added the pull from repository

          Show
          Sam Hemelryk added a comment - Fixed up the diff URL's and added the pull from repository
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - this has been integrated now
          In the future however if you could please make one commit with required changes and then a separate commit for white spaces and cleanup. This just makes it easier for us to review and track what is going on (The cleanup is certainly appreciated thank you )

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Mary - this has been integrated now In the future however if you could please make one commit with required changes and then a separate commit for white spaces and cleanup. This just makes it easier for us to review and track what is going on (The cleanup is certainly appreciated thank you ) Cheers Sam
          Hide
          Mary Evans added a comment -

          Hi Sam,

          Sorry...I got carried away and forgot what I was doing!
          But I will remember not to tidy up in future, and do that part as a separate commit.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Sam, Sorry...I got carried away and forgot what I was doing! But I will remember not to tidy up in future, and do that part as a separate commit. Cheers Mary
          Hide
          Michael de Raadt added a comment -

          Test result: worked nicely.

          Show
          Michael de Raadt added a comment - Test result: worked nicely.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for all the hard work. This is now part of Moodle, your favorite LMS.

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for all the hard work. This is now part of Moodle, your favorite LMS. Closing as fixed, ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: