Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29801

Messaging: unable to delete a message

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Test 1
      1. Install a new Moodle site.
      2. Confirm that there are the columns 'timeuserfromdeleted' and 'timeusertodeleted' in the message and message_read tables.
      Test 2
      1. Upgrade an existing Moodle site.
      2. Confirm that there are the columns 'timeuserfromdeleted' and 'timeusertodeleted' in the message and message_read tables.
      Test 3

      Please test this on all supported browsers

      1. Log in and visit another user's profile.
      2. Click 'Send a message'.
      3. Write a bunch of messages to this user (including ones that extend more than one line).
      4. Log in as the user you have been sending messages to and write some replies.
      5. Hover over a message.
      6. Confirm that the delete icon is on the same line as the first line of text for each message floated right.
      7. Confirm you can delete the message.
      8. Install the Hebrew language pack.
      9. Change your language to Hebrew.
      10. Hover over a message.
      11. On the message page confirm that the delete icon is on the same line as the first line of text for each message floated left.
      12. Confirm you can delete the message.
      Test 4

      Test this on a couple of mobile devices

      1. Log in and visit another user's profile.
      2. Click on the 'Message' button.
      3. Send them a message.
      4. Click on the 'Message' button.
      5. Click on 'View conversation'.
      6. Confirm there is no delete icon next to the message.
      7. Confirm that when you touch on the message the delete icon appears.
      8. Confirm you can delete the message.
      Test 5
      1. Log in and visit another user's profile.
      2. Click 'Send a message'.
      3. Write a bunch of messages to this user.
      4. Delete them.
      5. Confirm they are no longer visible.
      6. Log in as the user you sent the messages to and confirm they can still see them.
      7. Send some messages in response.
      8. Delete the messages that you received and the ones you sent.
      9. Confirm they are no longer visible.
      10. Log in as the first user and confirm you can see the messages sent.
      Test 6
      1. Log in as a user and visit another user's profile - make note of both their userids.
      2. Click 'Send a message'.
      3. Write a bunch of messages to this user.
      4. Log in as the user and send some messages in response.
      5. Log in as an admin and visit <yoursite>/message/index.php?user1=<user1id>&user2=<user2id>.
      6. Delete one of the messages on the left and delete one on the right.
      7. Log in as user 1 and confirm that the deleted messages are no longer visible.
      8. Log in as user 2 and confirm that the deleted message are still visible.
      9. Log in as an admin and visit <yoursite>/message/index.php?user1=<user2id>&user2=<user1id> (note the userids have been swapped).
      10. Delete one of the messages on the left and delete one on the right.
      11. Log in as user 2 and confirm that the deleted messages are no longer visible.
      12. Log in as user 1 and confirm that the deleted message are still visible.
      Test 7
      1. Run the behat test suite with the tag @core_message and ensure it passes.
      Test 8

      Exploratory testing. Use the messaging system as you normally would while also deleting messages here and there and check that it is working as expected.

      Show
      Test 1 Install a new Moodle site. Confirm that there are the columns 'timeuserfromdeleted' and 'timeusertodeleted' in the message and message_read tables. Test 2 Upgrade an existing Moodle site. Confirm that there are the columns 'timeuserfromdeleted' and 'timeusertodeleted' in the message and message_read tables. Test 3 Please test this on all supported browsers Log in and visit another user's profile. Click 'Send a message'. Write a bunch of messages to this user (including ones that extend more than one line). Log in as the user you have been sending messages to and write some replies. Hover over a message. Confirm that the delete icon is on the same line as the first line of text for each message floated right. Confirm you can delete the message. Install the Hebrew language pack. Change your language to Hebrew. Hover over a message. On the message page confirm that the delete icon is on the same line as the first line of text for each message floated left. Confirm you can delete the message. Test 4 Test this on a couple of mobile devices Log in and visit another user's profile. Click on the 'Message' button. Send them a message. Click on the 'Message' button. Click on 'View conversation'. Confirm there is no delete icon next to the message. Confirm that when you touch on the message the delete icon appears. Confirm you can delete the message. Test 5 Log in and visit another user's profile. Click 'Send a message'. Write a bunch of messages to this user. Delete them. Confirm they are no longer visible. Log in as the user you sent the messages to and confirm they can still see them. Send some messages in response. Delete the messages that you received and the ones you sent. Confirm they are no longer visible. Log in as the first user and confirm you can see the messages sent. Test 6 Log in as a user and visit another user's profile - make note of both their userids. Click 'Send a message'. Write a bunch of messages to this user. Log in as the user and send some messages in response. Log in as an admin and visit <yoursite>/message/index.php?user1=<user1id>&user2=<user2id>. Delete one of the messages on the left and delete one on the right. Log in as user 1 and confirm that the deleted messages are no longer visible. Log in as user 2 and confirm that the deleted message are still visible. Log in as an admin and visit <yoursite>/message/index.php?user1=<user2id>&user2=<user1id> (note the userids have been swapped). Delete one of the messages on the left and delete one on the right. Log in as user 2 and confirm that the deleted messages are no longer visible. Log in as user 1 and confirm that the deleted message are still visible. Test 7 Run the behat test suite with the tag @core_message and ensure it passes. Test 8 Exploratory testing. Use the messaging system as you normally would while also deleting messages here and there and check that it is working as expected.
    • Workaround:
      Hide

      Use phpMyAdmin to delete messages, manually.

      Show
      Use phpMyAdmin to delete messages, manually.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29801_master
    • Sprint:
      Team A Sprint 1, Team Beards Sprint 5, Team Beards Sprint 6
    • Issue size:
      Small

      Description

      I was asked, as system administrator, by a Teacher to delete some problematic Messages
      And i was unable to, from the UI.

      Obviously, it was deleted from the DB by using SQL (phpMyAdmin)

      Is there any way for the user to delete messages from the personal messages stream or for a Manager to delete messages from some user's streams (offensive messages) ?

        Attachments

        1. 29801_css.patch
          291 kB
        2. delete_icon_update_2.png
          delete_icon_update_2.png
          98 kB
        3. delete_icon_update_3_mockup.jpg
          delete_icon_update_3_mockup.jpg
          52 kB
        4. delete_icon_update_3.png
          delete_icon_update_3.png
          72 kB
        5. delete_icon_update_4.png
          delete_icon_update_4.png
          72 kB
        6. delete_icon_update.png
          delete_icon_update.png
          128 kB
        7. Screen Shot 2015-03-31 at 2.57.11 pm.png
          Screen Shot 2015-03-31 at 2.57.11 pm.png
          210 kB
        8. Screen Shot 2015-04-01 at 9.03.28 pm.png
          Screen Shot 2015-04-01 at 9.03.28 pm.png
          38 kB

          Issue Links

            Activity

              People

              • Votes:
                59 Vote for this issue
                Watchers:
                48 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15