Moodle
  1. Moodle
  2. MDL-29810

Teacher shows up alphabetically in assignment grading when using the "next" feature

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Assignment (2.2)
    • Labels:
      None
    • Testing Instructions:
      Hide
      • Create a course with 1 teacher and at least 2 students enrolled.
      • Log in as the teacher.
      • Create an "Advanced uploading of files assignment" (with default settings).
      • Open the assignment, and click on "No attempts have been made on this assignment".
      • Click "grade" for the first student in the list.
      • Click "next" repeatedly until end of list is reached.

      Verify that, while going through the student list with the "Next" button, all student are shown (in sequence) but that the teacher does not appear in the list.

      Show
      Create a course with 1 teacher and at least 2 students enrolled. Log in as the teacher. Create an "Advanced uploading of files assignment" (with default settings). Open the assignment, and click on "No attempts have been made on this assignment". Click "grade" for the first student in the list. Click "next" repeatedly until end of list is reached. Verify that, while going through the student list with the "Next" button, all student are shown (in sequence) but that the teacher does not appear in the list.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19336

      Description

      This is similar to http://tracker.moodle.org/browse/MDL-25872 but once that issue was fixed, Moodle still asks for a grade for the teacher when using the standard grading feature and the "save and next" or "next button".

        Activity

        Hide
        Henning Bostelmann added a comment -

        Similar fix as in MDL-25872: capability changed from mod/assignment:view to mod/assignment:submit. See github.

        Show
        Henning Bostelmann added a comment - Similar fix as in MDL-25872 : capability changed from mod/assignment:view to mod/assignment:submit. See github.
        Hide
        Jason Fowler added a comment -

        Seems to be in order

        Show
        Jason Fowler added a comment - Seems to be in order
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks Henning this has now been integrated

        Show
        Sam Hemelryk added a comment - Thanks Henning this has now been integrated
        Hide
        Ankit Agarwal added a comment -

        all good!
        Thanks

        Show
        Ankit Agarwal added a comment - all good! Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has been sent upstream (already available @ git and cvs repos). Many, many thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has been sent upstream (already available @ git and cvs repos). Many, many thanks! Closing as fixed, ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: