Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29821

Navigation to notes page broken if user cannot access all groups

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.1.4, 2.2.1
    • Component/s: Navigation
    • Labels:
      None
    • Testing Instructions:
      Hide
      • Enable notes on your Moodle site.
      • Change capability setting "moodle/site:accessallgroups" to "not set" for role "Nonediting teacher".
      • Create a course.
      • Create a group in the course (make sure that the groupid does not happen to be the same number as the courseid).
      • Enrol a nonediting teacher into the course and group.
      • Log in as the nonediting teacher.
      • In the navigation outline, navigate to the course entry, then "Participants", then click on "Notes".
        Verify that the notes page is being displayed.
      Show
      Enable notes on your Moodle site. Change capability setting "moodle/site:accessallgroups" to "not set" for role "Nonediting teacher". Create a course. Create a group in the course (make sure that the groupid does not happen to be the same number as the courseid). Enrol a nonediting teacher into the course and group. Log in as the nonediting teacher. In the navigation outline, navigate to the course entry, then "Participants", then click on "Notes". Verify that the notes page is being displayed.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When a user has the capability "moodle/notes:view" but not "moodle/site:accessallgroups", he cannot navigate to the notes page using the navigation outline.

      Steps to reproduce:

      • Enable notes on your Moodle site.
      • Change capability setting "moodle/site:accessallgroups" to "not set" for role "Nonediting teacher".
      • Create a course.
      • Create a group in the course (make sure that the groupid does not happen to be the same number as the courseid).
      • Enrol a nonediting teacher into the course and group.
      • Log in as the nonediting teacher.
      • In the navigation outline, navigate to the course entry, then "Participants", then "Notes".
      • Clicking on "Notes" will result in an error message: "Can not find data record in database table course."

      Background: The notes system does not support filtering by group. However, the outline tries to pass a group filter, generating a link to .../notes/index.php?filtertype=course&filterselect=<id> where <id> is the group id. This invalid parameter leads to the error message.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jan/12