Moodle

Quiz overdue time mis-displayed on the review page

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.2, 2.2
  • Fix Version/s: 2.1.3
  • Component/s: Quiz
  • Labels:
    None
  • Testing Instructions:
    Hide

    1. Create a quiz with a (short) time limit.
    2. Attempt it as a student, and submit it late. The easiest way to do that is by turning off JS.
    3. Review the quiz as a teacher, make sure the amount of time overdue is clearly displayed.

    Show
    1. Create a quiz with a (short) time limit. 2. Attempt it as a student, and submit it late. The easiest way to do that is by turning off JS. 3. Review the quiz as a teacher, make sure the amount of time overdue is clearly displayed.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

format_time is called twice. See screen-shot on MDL-29627 for more details.

Issue Links

has a non-specific relationship to

Improvement - An enhancement to an existing Moodle feature. MDL-29627 Quiz access rules should be a type of plugin

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Aparup Banerjee added a comment -

Thanks Tim, this has been integrated and is ready for testing.

Show
Aparup Banerjee added a comment - Thanks Tim, this has been integrated and is ready for testing.
Hide
Permalink
Ankit Agarwal added a comment -

Works!
Test passed
Thanks

Show
Ankit Agarwal added a comment - Works! Test passed Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Done, your delicious hacks have been sent upstream, many thanks!

Closing as fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Done, your delicious hacks have been sent upstream, many thanks! Closing as fixed, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: