Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.2
-
Component/s: Navigation, Themes
-
Labels:None
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-29830_master -
Pull Master Diff URL:
Description
change the name of an activity to a new one very long and WITHOUT SPACES. Choose, for instance, "very_long_name_missing_spaces" (without quotes, if you like)
Look at the navigation block.
You should see something like attachment01.png
In order to have the name not overflowing the block box (attachment02.png) line 3 of the file the file /HEAD/blocks/navigation/styles.css should be changed from
|
.block_navigation .block_tree li {margin:3px;list-style: none;padding:0;}
|
to
|
.block_navigation .block_tree li {margin:3px;list-style: none;padding:0;overflow:hidden;}
|
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Sure Mary, thanks.
I'll try do all my best before the end of this week.
I am quite a busy in these hours but do not worry!
How can I ask for a peer review? 
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
Thanks guys this has been integrated now. Can you please in future make the commit messages something that relates to what has changed so that it is easy to get a summary.
In the case of this issue I cherry-picked the commit to all branches and changed the message to:
MDL-29830theme_base: Fixed overflow issue with navigation items
Cheers
Sam
Tested and passed during integration
And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!
Ciao
Hi Daniele,
The patch is 'spot on!' however, I would be tempted to make the change in theme/base/blocks.css rather than @source
If you want to submit this as we talked about in our earlier discussion, make the change to base theme, and push to GITHUB (master only). Ask me to Peer Review it, then if it is OK Sam can cherry-pick to stable branches.
On the other hand Sam might even assign this to you as it is a pretty easy fix.
Thanks
Mary