Moodle
  1. Moodle
  2. MDL-29830

navigation block should cut too long names (SOLUTION INCLUDED)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Navigation, Themes
    • Labels:
      None
    • Rank:
      19355

      Description

      change the name of an activity to a new one very long and WITHOUT SPACES. Choose, for instance, "very_long_name_missing_spaces" (without quotes, if you like)
      Look at the navigation block.
      You should see something like attachment01.png
      In order to have the name not overflowing the block box (attachment02.png) line 3 of the file the file /HEAD/blocks/navigation/styles.css should be changed from

       
      .block_navigation .block_tree li {margin:3px;list-style: none;padding:0;}
      

      to

       
      .block_navigation .block_tree li {margin:3px;list-style: none;padding:0;overflow:hidden;}
      

        Activity

        Hide
        Mary Evans added a comment -

        Hi Daniele,

        The patch is 'spot on!' however, I would be tempted to make the change in theme/base/blocks.css rather than @source

        If you want to submit this as we talked about in our earlier discussion, make the change to base theme, and push to GITHUB (master only). Ask me to Peer Review it, then if it is OK Sam can cherry-pick to stable branches.

        On the other hand Sam might even assign this to you as it is a pretty easy fix.

        Thanks
        Mary

        Show
        Mary Evans added a comment - Hi Daniele, The patch is 'spot on!' however, I would be tempted to make the change in theme/base/blocks.css rather than @source If you want to submit this as we talked about in our earlier discussion, make the change to base theme, and push to GITHUB (master only). Ask me to Peer Review it, then if it is OK Sam can cherry-pick to stable branches. On the other hand Sam might even assign this to you as it is a pretty easy fix. Thanks Mary
        Hide
        Daniele Cordella added a comment -

        Sure Mary, thanks.
        I'll try do all my best before the end of this week.
        I am quite a busy in these hours but do not worry!

        Show
        Daniele Cordella added a comment - Sure Mary, thanks. I'll try do all my best before the end of this week. I am quite a busy in these hours but do not worry!
        Hide
        Daniele Cordella added a comment -

        How can I ask for a peer review?

        Show
        Daniele Cordella added a comment - How can I ask for a peer review?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
        Hide
        Sam Hemelryk added a comment -

        Thanks guys this has been integrated now. Can you please in future make the commit messages something that relates to what has changed so that it is easy to get a summary.
        In the case of this issue I cherry-picked the commit to all branches and changed the message to:

        MDL-29830 theme_base: Fixed overflow issue with navigation items

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks guys this has been integrated now. Can you please in future make the commit messages something that relates to what has changed so that it is easy to get a summary. In the case of this issue I cherry-picked the commit to all branches and changed the message to: MDL-29830 theme_base: Fixed overflow issue with navigation items Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Tested and passed during integration

        Show
        Sam Hemelryk added a comment - Tested and passed during integration
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: