Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29836

Using "More details" string from core makes webservices translation incorrect

    Details

      Description

      In admin/settings/plugins.php, the string "supplyinfo" (which translates to "More details") is used to mean "Show a docs page about using security keys".

      In login/signup_form.php this same string is used to mean "Dear user, provide more information about yourself".

      This string cannot be correctly translated to other languages while keeping both meanings. The string from admin/settings/plugins.php should be separated to a new sting for this second meaning in Web services.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for providing this change.

            Show
            salvetore Michael de Raadt added a comment - Thanks for providing this change.
            Hide
            jerome Jérôme Mouneyrac added a comment -

            Yes it seems weird to use the string from the login. The patch is good, submitting. Thanks Vadim.

            Show
            jerome Jérôme Mouneyrac added a comment - Yes it seems weird to use the string from the login. The patch is good, submitting. Thanks Vadim.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks,

            I've integrated this (on 2.3 only), thanks

            Show
            poltawski Dan Poltawski added a comment - Thanks, I've integrated this (on 2.3 only), thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12