Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.1.3
    • Component/s: Administration
    • Labels:
      None
    • Testing Instructions:
      Hide

      use testing instructions from the linked issue:
      1/ enable full debug
      2/ access your site with a different URL then is specified in wwwroot (ip instead of DNS name for example)
      3/ no warnings or notices expected

      Show
      use testing instructions from the linked issue: 1/ enable full debug 2/ access your site with a different URL then is specified in wwwroot (ip instead of DNS name for example) 3/ no warnings or notices expected
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w42_MDL-29862_m22_fullmeinit

      Description

      The initialisation of FULLME and friends was moved after session start, that is very wrong because we must not start session on wrong www roots because it might mess up session cookies...

      Solution is to set up fake $USER object instead...

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Petr Skoda added a comment -

            I am working on a better patch for master, we need to deal with redirects before PAGE and OUTPUT is initialised anyway

            Show
            Petr Skoda added a comment - I am working on a better patch for master, we need to deal with redirects before PAGE and OUTPUT is initialised anyway
            Hide
            Petr Skoda added a comment -

            resubmitting, I have finally decided to create new issue for the refactoring/cleanup, ciao

            Show
            Petr Skoda added a comment - resubmitting, I have finally decided to create new issue for the refactoring/cleanup, ciao
            Hide
            Sam Hemelryk added a comment -

            Thanks for cleaning that up Petr - sorry I missed that requirement in the first place.

            Show
            Sam Hemelryk added a comment - Thanks for cleaning that up Petr - sorry I missed that requirement in the first place.
            Hide
            Jason Fowler added a comment -

            All good

            Show
            Jason Fowler added a comment - All good
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Done, your delicious hacks have been sent upstream, many thanks!

            Closing as fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Done, your delicious hacks have been sent upstream, many thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: