Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29864

Theme's with spaces in font-family incorrectly handled by minify library

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.2
    • Component/s: Libraries, Themes
    • Labels:
      None
    • Testing Instructions:
      Hide
      • Modify /theme/standard/style/core.css to include a font-family of 'Trebuchet MS' (without quotes) - e.g. body {font-family:Trebuchet MS, Arial, Verdana, Helvetica, sans-serif;padding: 4px;}
      • Clear Caches
      • Ensure Theme Designed mode is not enabled
      • Reload the page
      • Use an inspector to view the CSS element.

      Expected result:
      font-family: Trebuchet MS,Arial,Verdana,Helvetica,sans-serif;

      Actual result:
      font-family: TrebuchetMS,Arial,Verdana,Helvetica,sans-serif;

      Show
      Modify /theme/standard/style/core.css to include a font-family of 'Trebuchet MS' (without quotes) - e.g. body {font-family:Trebuchet MS, Arial, Verdana, Helvetica, sans-serif;padding: 4px;} Clear Caches Ensure Theme Designed mode is not enabled Reload the page Use an inspector to view the CSS element. Expected result: font-family: Trebuchet MS,Arial,Verdana,Helvetica,sans-serif; Actual result: font-family: TrebuchetMS,Arial,Verdana,Helvetica,sans-serif;
    • Workaround:
      Hide

      Wrap any font which has spaces in it's name in quotes (e.g. Trebuchet MS becomes 'Trebuchet MS')

      Show
      Wrap any font which has spaces in it's name in quotes (e.g. Trebuchet MS becomes 'Trebuchet MS')
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29864-master-2

      Description

      We've seen an issue where, if a theme contains a font-family declaration with a space in it, for example Trebuchet MS, it is minified to TrebuchetMS.

      This is already reported, and fixed in the upstream minify library under bug 210 (http://code.google.com/p/minify/issues/detail?id=210).
      Fixes 438 (Dec 2010) and 457 (June 2011) address this issue in the upstream library but there hasn't been a release since June 2009.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    5/Dec/11