Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29887

remove deprecated swfobject lib

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: Libraries
    • Labels:
      None

      Description

      We are not using swfobject since the last mediafilter rewrite (with the exception of webservice test client)

      Contrib code that still uses the old style swfobject embedding can:

      • switch to YUI flash embedding
      • embed manually
      • switch to HTML5 (preferable)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Uhm,

            just guessing what happens with the $flashvars originally passed.

            It seems that the tester uses / needs 'rooturl' defined and I cannot see it in new code:

            this.rooturl = Application.application.parameters.rooturl

            Halting till explanation arrives, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Uhm, just guessing what happens with the $flashvars originally passed. It seems that the tester uses / needs 'rooturl' defined and I cannot see it in new code: this.rooturl = Application.application.parameters.rooturl Halting till explanation arrives, ciao
            Hide
            skodak Petr Skoda added a comment -

            arrgghh, fixing

            Show
            skodak Petr Skoda added a comment - arrgghh, fixing
            Hide
            skodak Petr Skoda added a comment -

            should be fixed now, the amf test client works fine for me now, sorrrry

            Show
            skodak Petr Skoda added a comment - should be fixed now, the amf test client works fine for me now, sorrrry
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Pass!

            Show
            samhemelryk Sam Hemelryk added a comment - Pass!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Done, your delicious hacks have been sent upstream, many thanks!

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Done, your delicious hacks have been sent upstream, many thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/11