Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29516 DB layer improvements 2.3 META
  3. MDL-29894

Prevent objects to be passed to moodle_database as params

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Testing Instructions:
      Hide

      1/ run functional DB tests for all 5 supported drivers
      2/ try install for one DB type (they all throw the same errors now)
      3/ browse around a bit - please report any regressions here or as separate issues

      Show
      1/ run functional DB tests for all 5 supported drivers 2/ try install for one DB type (they all throw the same errors now) 3/ browse around a bit - please report any regressions here or as separate issues
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w12_MDL-29894_m23_objectparams

      Description

      Before 2.2, the behavior of passing objects to moodle_database methods was undefined and, up to some point, the __toString() magic method was doing its work in a few cases.

      But it was not fully supported nor cross-db (MDL-29339) so finally it has been decided to be stricter and prevent (coding exception) any use of objects being passed as params. Caller should perform always the cast instead.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              stronk7 Eloy Lafuente (stronk7) created issue -
              stronk7 Eloy Lafuente (stronk7) made changes -
              Field Original Value New Value
              Fix Version/s DEV backlog [ 10464 ]
              Priority Minor [ 4 ] Blocker [ 1 ]
              Difficulty Easy
              stronk7 Eloy Lafuente (stronk7) made changes -
              Link This issue has been marked as being related by MDL-29339 [ MDL-29339 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Link This issue has been marked as being related by MDL-30508 [ MDL-30508 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Assignee Eloy Lafuente (stronk7) [ stronk7 ] moodle.com [ moodle.com ]
              skodak Petr Skoda made changes -
              Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
              timhunt Tim Hunt made changes -
              Link This issue will help resolve MDL-31828 [ MDL-31828 ]
              skodak Petr Skoda made changes -
              Parent MDL-29516 [ 47690 ]
              Rank (Obsolete) 179140000000
              Issue Type Bug [ 1 ] Sub-task [ 5 ]
              skodak Petr Skoda made changes -
              Status Open [ 1 ] Development in progress [ 3 ]
              skodak Petr Skoda made changes -
              Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
              Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w12_MDL-32052_m23_authtype
              Pull Master Branch w12_MDL-32052_m23_authtype
              Pull from Repository git://github.com/skodak/moodle.git
              Fix Version/s 2.3 [ 10657 ]
              Fix Version/s DEV backlog [ 10464 ]
              Testing Instructions 1/ run functional DB tests for all 5 supported drivers
              2/ try install for one DB type (they all throw the same errors now)
              3/ browse around a bit - please report any regressions here or as separate issues
              samhemelryk Sam Hemelryk made changes -
              Currently in integration Yes [ 10041 ]
              poltawski Dan Poltawski made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Integrator poltawski
              poltawski Dan Poltawski made changes -
              Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
              salvetore Michael de Raadt made changes -
              Tester rwijaya
              rwijaya Rossiani Wijaya made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              nebgor Aparup Banerjee made changes -
              Status Testing in progress [ 10011 ] Waiting for testing [ 10005 ]
              nebgor Aparup Banerjee made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              Tester rwijaya nebgor
              nebgor Aparup Banerjee made changes -
              Link This issue discovered while testing MDL-32152 [ MDL-32152 ]
              nebgor Aparup Banerjee made changes -
              Status Testing in progress [ 10011 ] Tested [ 10006 ]
              samhemelryk Sam Hemelryk made changes -
              Status Tested [ 10006 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]
              Currently in integration Yes [ 10041 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Integration date 23/Mar/12

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12