Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3, 2.3.4, 2.4.1, 3.5.1
-
Fix Version/s: 3.6
-
Component/s: Administration
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_35_STABLE
-
Fixed Branches:MOODLE_36_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
When admin_externalpage_setup() is called, there is no need to call require_login(). For example it could be removed from the following code:
require_login();
|
|
admin_externalpage_setup('letters');
|
Please confirm that my reasoning is correct and I will prepare a patch for all affected areas.
Possible list (for review) of all the files where both functions are used:
grade/edit/letter/index.php
grade/edit/scale/edit.php
grade/edit/outcome/edit.php
grade/edit/outcome/edit.php
admin/user/user_bulk_message.php
admin/user/user_bulk_forcepasswordchange.php
admin/user/user_bulk_delete.php
admin/user/user_bulk_download.php
admin/user/user_bulk_enrol.php
admin/user/user_bulk_confirm.php
admin/qbehaviours.php
admin/report/security/index.php
admin/filters.php
admin/roles/define.php
admin/roles/manage.php
admin/qtypes.php
admin/mnet/services.php
admin/mnet/delete.php
admin/mnet/testclient.php
admin/mnet/access_control.php
admin/mnet/trustedhosts.php
admin/mnet/index.php
admin/mnet/peers.php
admin/mnet/profilefields.php
admin/purgecaches.php
admin/tool/xmldb/index.php
admin/tool/spamcleaner/index.php
admin/tool/capability/index.php
admin/tool/uploaduser/index.php
admin/tool/uploaduser/picture.php
admin/tool/qeupgradehelper/convertquiz.php
admin/tool/qeupgradehelper/resetquiz.php
admin/tool/qeupgradehelper/listupgraded.php
admin/tool/qeupgradehelper/index.php
admin/tool/qeupgradehelper/extracttestcase.php
admin/tool/qeupgradehelper/listtodo.php
admin/tool/qeupgradehelper/cronsetup.php
admin/tool/qeupgradehelper/listpreupgrade.php
admin/tool/innodb/index.php
admin/tool/dbtransfer/index.php
admin/tool/dbtransfer/dbexport.php
admin/tool/unsuproles/index.php
admin/tool/health/index.php
cohort/index.php
comment/index.php
course/pending.php
course/index.php
course/index.php
course/category.php
course/category.php
lib/adminlib.php