Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29896

Navigation block: URL and file (resource) links broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.2
    • Component/s: Navigation
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. In a course week, click Add a resource / URL.
      2. Set name 'Google', description 'x', external URL 'http://www.google.com/', display 'In pop-up'. (Leave other options default.)
      3. Click 'Save and return to course'.
      4. In a course week, click Add a resource / File.
      5. Set name 'File', description 'x', click 'Add...' and select any PDF file. Set display to 'In pop-up'. Leave other options default.
      6. Click 'Save and return to course'.
      7. Where they appear within the course week, click both links.

      • Verify that they still work (to launch Google, and the PDF file, in popup windows.)
        8. In the Navigation block, expand the week in question.
      • Verify that both items appear as normal clickable links.
        9. Click on each link in the navigation block.
      • Verify that both links still work.
      Show
      1. In a course week, click Add a resource / URL. 2. Set name 'Google', description 'x', external URL 'http://www.google.com/', display 'In pop-up'. (Leave other options default.) 3. Click 'Save and return to course'. 4. In a course week, click Add a resource / File. 5. Set name 'File', description 'x', click 'Add...' and select any PDF file. Set display to 'In pop-up'. Leave other options default. 6. Click 'Save and return to course'. 7. Where they appear within the course week, click both links. Verify that they still work (to launch Google, and the PDF file, in popup windows.) 8. In the Navigation block, expand the week in question. Verify that both items appear as normal clickable links. 9. Click on each link in the navigation block. Verify that both links still work.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29896-master

      Description

      On my Moodle 2.2 dev system, when you add a URL or file resource and you set it to open in a popup window, the link in the navigation block stops working altogether.

      This might possibly be related to changes I made a while back, so I'll have a look at it initially at least.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Mar/12