Moodle
  1. Moodle
  2. MDL-29898

Incorrect documentation in admin/cli/install_database.php

        Details

        • Testing Instructions:
          Hide
          1. Create empty database and point configuration at it.
          2. As web server user run: php admin/cli/install_database.php --agree-license --fullname "fullname" --shortname "shortname" --adminpass=password
          3. Verify that the site has a fullname and shortname of 1
          4. Drop and re-create the database
          5. As web server user run: php admin/cli/install_database.php --agree-license --fullname="fullname" --shortname="shortname" --adminpass=password
          6. Verify that the fullname and shortname are now set correctly
          Show
          Create empty database and point configuration at it. As web server user run: php admin/cli/install_database.php --agree-license --fullname "fullname" --shortname "shortname" --adminpass=password Verify that the site has a fullname and shortname of 1 Drop and re-create the database As web server user run: php admin/cli/install_database.php --agree-license --fullname="fullname" --shortname="shortname" --adminpass=password Verify that the fullname and shortname are now set correctly
        • Difficulty:
          Easy
        • Affected Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-29898-master-1
        • Pull Master Diff URL:
        • Rank:
          19429

          Description

          Documentation suggests that fullname and shortname options are:
          --fullname
          --shortname

          They are in fact
          --fullname=STRING
          --shortname=STRING

          Trying to use the former results in a fullname or shortname of "1"

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Ankit Agarwal added a comment -

            Hi,
            Looks good to me!
            Thanks for reporting and fixing this.
            Submitting for integration.
            Thanks

            Show
            Ankit Agarwal added a comment - Hi, Looks good to me! Thanks for reporting and fixing this. Submitting for integration. Thanks
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Thanks guys this has been integrated now

            Show
            Sam Hemelryk added a comment - Thanks guys this has been integrated now
            Hide
            Permalink
            Aparup Banerjee added a comment -

            this works! \o/

            Show
            Aparup Banerjee added a comment - this works! \o/
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            And this has been sent upstream (already available @ git and cvs repos). Many, many thanks!

            Closing as fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - And this has been sent upstream (already available @ git and cvs repos). Many, many thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: