Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.1.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Administration, Themes
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. Switch theme to Sky High.
      2. Select Report in Site-Administation
      3. Try printing a report (eg: Config Changes as this will have lots of data)
      4. Check to see if print out is incomplete.

      Show
      1. Switch theme to Sky High. 2. Select Report in Site-Administation 3. Try printing a report (eg: Config Changes as this will have lots of data) 4. Check to see if print out is incomplete.
    • Workaround:
      Hide

      A suggested workaround this problem is the following patch by my mentor Dietmar Wagner

       
      ********************************************
      A patch for the report "Config changes":
      ********************************************
      admin/report/configlog/index.php
      ========================
      @@-12,1 +12,1@@
      - admin_externalpage_setup('reportconfiglog');
      + admin_externalpage_setup('reportconfiglog', '', null, '', array('pagelayout'=>'report'));
       

      With the following CSS added to theme/sky_high/style/pagelayout.css

      /* Report layout
      -------------------------*/
      .pagelayout-report #page-content #region-main-box { margin-left: 0px;}
      .pagelayout-report #page-content #region-post-box { margin-left: -[[setting:regionwidth]];}
      .pagelayout-report #page-content #region-main { margin-left: [[setting:regionwidth]];}
      .pagelayout-report #page-content #region-pre { left: [[setting:regionwidth]]; width: [[setting:regionwidth]];}
      .pagelayout-report #page-content #region-post { width: 0%;}
       
      /* Print layout
      -------------------------*/
      @media print {
          .pagelayout-report #page-content #region-main-box { margin-left: 0px;}
          .pagelayout-report #page-content #region-main-box #region-post-box { margin-left: 0px;}
          .pagelayout-report #page-content #region-main-box #region-post-box #region-main-wrap #region-main { margin-left: 0px;}
          .pagelayout-report #page-content #region-main-box #region-post-box #region-pre { width: 0px;}
          .pagelayout-report #page-content #region-main-box #region-post-box #region-main-wrap #region-main .region-content table.generaltable {
               font-size:60%;
           }
      }

      Show
      A suggested workaround this problem is the following patch by my mentor Dietmar Wagner   ******************************************** A patch for the report "Config changes": ******************************************** admin/report/configlog/index.php ======================== @@-12,1 +12,1@@ - admin_externalpage_setup('reportconfiglog'); + admin_externalpage_setup('reportconfiglog', '', null, '', array('pagelayout'=>'report'));   With the following CSS added to theme/sky_high/style/pagelayout.css /* Report layout -------------------------*/ .pagelayout-report #page-content #region-main-box { margin-left: 0px;} .pagelayout-report #page-content #region-post-box { margin-left: -[[setting:regionwidth]];} .pagelayout-report #page-content #region-main { margin-left: [[setting:regionwidth]];} .pagelayout-report #page-content #region-pre { left: [[setting:regionwidth]]; width: [[setting:regionwidth]];} .pagelayout-report #page-content #region-post { width: 0%;}   /* Print layout -------------------------*/ @media print { .pagelayout-report #page-content #region-main-box { margin-left: 0px;} .pagelayout-report #page-content #region-main-box #region-post-box { margin-left: 0px;} .pagelayout-report #page-content #region-main-box #region-post-box #region-main-wrap #region-main { margin-left: 0px;} .pagelayout-report #page-content #region-main-box #region-post-box #region-pre { width: 0px;} .pagelayout-report #page-content #region-main-box #region-post-box #region-main-wrap #region-main .region-content table.generaltable { font-size:60%; } }
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29904-master

      Description

      Printing something like quiz results is truncated when using Sky High as a theme. For example, a quiz with 21 attempts gives a print out of 8 attempts on the first two pages, and two blank pages. The same quiz printed using another theme prints the total number of attempts/results.

        Gliffy Diagrams

        1. report.pdf
          952 kB
          Mary Evans

          Issue Links

            Activity

            rob13 Rob created issue -
            lazydaisy Mary Evans made changes -
            Field Original Value New Value
            Assignee Patrick Malley [ ptrkmkl ] Mary Evans [ lazydaisy ]
            lazydaisy Mary Evans made changes -
            Summary cannot print using Sky High theme Printing truncates after first few items in a report in Sky High theme
            Fix Version/s 2.2 [ 10656 ]
            Fix Version/s 2.1 [ 10370 ]
            Fix Version/s 2.0 [ 10122 ]
            Peer reviewer samhemelryk
            Testing Instructions Switch theme to Sky High. Try printing quiz results or stats. Notice incomplete print out. 1. Switch theme to Sky High.
            2. Select Report in Site-Administation
            3. Try printing a report (eg: Config Changes as this will have lots of data)
            4. Check to see if print out is incomplete.
            Description Printing something link quiz results is truncated when using Sky High as a theme. For example, a quiz with 21 attempts gives a print out of 8 attempts on the first two pages, and two blank pages. The same quiz printed using another theme prints the total number of attempts/results. Printing something like quiz results is truncated when using Sky High as a theme. For example, a quiz with 21 attempts gives a print out of 8 attempts on the first two pages, and two blank pages. The same quiz printed using another theme prints the total number of attempts/results.
            Priority Minor [ 4 ] Blocker [ 1 ]
            Workaround Switch to another theme if printing is necessary. Switch to Standard theme if printing is necessary.
            lazydaisy Mary Evans made changes -
            Status Open [ 1 ] Development in progress [ 3 ]
            lazydaisy Mary Evans made changes -
            Attachment report.pdf [ 25838 ]
            lazydaisy Mary Evans made changes -
            Assignee Mary Evans [ lazydaisy ] Rajesh Taneja [ rajeshtaneja ]
            Component/s Administration [ 10050 ]
            Component/s Themes [ 10088 ]
            lazydaisy Mary Evans made changes -
            Component/s Themes [ 10088 ]
            lazydaisy Mary Evans made changes -
            Parent MDL-30238 [ 48775 ]
            Rank (Obsolete) 179240000000
            Issue Type Bug [ 1 ] Sub-task [ 5 ]
            lazydaisy Mary Evans made changes -
            Link This issue will help resolve MDL-30238 [ MDL-30238 ]
            lazydaisy Mary Evans made changes -
            Workaround Switch to Standard theme if printing is necessary. A suggested workaround this problem is the following patch by my mentor Dietmar Wagner
            {noformat}

            ********************************************
            A patch for the report "Config changes":
            ********************************************
            admin/report/configlog/index.php
            ========================
            @@-12,1 +12,1@@
            - admin_externalpage_setup('reportconfiglog');
            + admin_externalpage_setup('reportconfiglog', '', null, '', array('pagelayout'=>'report'));

            {noformat}

            With the following CSS added to theme/sky_high/style/pagelayout.css

            {noformat}
            /* Report layout
            -------------------------*/
            .pagelayout-report #page-content #region-main-box { margin-left: 0px;}
            .pagelayout-report #page-content #region-post-box { margin-left: -[[setting:regionwidth]];}
            .pagelayout-report #page-content #region-main { margin-left: [[setting:regionwidth]];}
            .pagelayout-report #page-content #region-pre { left: [[setting:regionwidth]]; width: [[setting:regionwidth]];}
            .pagelayout-report #page-content #region-post { width: 0%;}

            /* Print layout
            -------------------------*/
            @media print {
                .pagelayout-report #page-content #region-main-box { margin-left: 0px;}
                .pagelayout-report #page-content #region-main-box #region-post-box { margin-left: 0px;}
                .pagelayout-report #page-content #region-main-box #region-post-box #region-main-wrap #region-main { margin-left: 0px;}
                .pagelayout-report #page-content #region-main-box #region-post-box #region-pre { width: 0px;}
                .pagelayout-report #page-content #region-main-box #region-post-box #region-main-wrap #region-main .region-content table.generaltable {
                     font-size:60%;
                 }
            }
            {noformat}
            dxxw Dietmar Wagner made changes -
            lazydaisy Mary Evans made changes -
            Assignee Rajesh Taneja [ rajeshtaneja ] Mary Evans [ lazydaisy ]
            lazydaisy Mary Evans made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Pull Master Diff URL https://github.com/lazydaisy/moodle/compare/master...MDL-29904-master
            Pull Master Branch MDL-29904-master
            Pull 2.0 Diff URL https://github.com/lazydaisy/moodle/compare/master...MDL-29904-M20
            Pull from Repository git://github.com/lazydaisy/moodle/
            Pull 2.0 Branch MDL-29904-M20
            Pull 2.1 Branch MDL-29904-M21
            Pull 2.1 Diff URL https://github.com/lazydaisy/moodle/compare/master...MDL-29904-M21
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.0.6 [ 11250 ]
            Fix Version/s 2.1.3 [ 11251 ]
            Fix Version/s 2.0 [ 10122 ]
            Fix Version/s 2.1 [ 10370 ]
            Fix Version/s 2.2 [ 10656 ]
            nebgor Aparup Banerjee made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester nebgor
            nebgor Aparup Banerjee made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 25/Nov/11

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11