Moodle
  1. Moodle
  2. MDL-29914

Dear librarykiller, please target lib/pear/PHP

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Libraries
    • Labels:
      None
    • Rank:
      19449

      Description

      This is only used by an abortive attempt to implement codesniffer in core, which Nico did some years ago, and which never worked very well. (It has a very out-of-date version of codesniffer, and the Moodle-specific code is mixed up with the PEAR code.)

      We now have local/codechecker as a self-contained plugin that includes its own up-to-date copy of the PEAR library.

        Activity

        Hide
        Petr Škoda added a comment -

        yay! I thought it is alive, I am going to study both local/codechecker and the core stuff, thanks!

        Show
        Petr Škoda added a comment - yay! I thought it is alive, I am going to study both local/codechecker and the core stuff, thanks!
        Hide
        Petr Škoda added a comment -

        oh, it looks like Eloys child - used from unittests, reassigning to him

        Show
        Petr Škoda added a comment - oh, it looks like Eloys child - used from unittests, reassigning to him
        Hide
        Petr Škoda added a comment -

        grrrrr, wrong dir, I looked at spikephpcoverage....

        Show
        Petr Škoda added a comment - grrrrr, wrong dir, I looked at spikephpcoverage....
        Hide
        Petr Škoda added a comment -

        thanks for the report

        Show
        Petr Škoda added a comment - thanks for the report
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! 2.2 release docs updated to add this.

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! 2.2 release docs updated to add this.
        Hide
        Sam Hemelryk added a comment -

        Pass

        Show
        Sam Hemelryk added a comment - Pass
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Done, your delicious hacks have been sent upstream, many thanks!

        Closing as fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Done, your delicious hacks have been sent upstream, many thanks! Closing as fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: