Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29914

Dear librarykiller, please target lib/pear/PHP

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Libraries
    • Labels:
      None

      Description

      This is only used by an abortive attempt to implement codesniffer in core, which Nico did some years ago, and which never worked very well. (It has a very out-of-date version of codesniffer, and the Moodle-specific code is mixed up with the PEAR code.)

      We now have local/codechecker as a self-contained plugin that includes its own up-to-date copy of the PEAR library.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            skodak Petr Skoda added a comment -

            yay! I thought it is alive, I am going to study both local/codechecker and the core stuff, thanks!

            Show
            skodak Petr Skoda added a comment - yay! I thought it is alive, I am going to study both local/codechecker and the core stuff, thanks!
            Hide
            skodak Petr Skoda added a comment -

            oh, it looks like Eloys child - used from unittests, reassigning to him

            Show
            skodak Petr Skoda added a comment - oh, it looks like Eloys child - used from unittests, reassigning to him
            Hide
            skodak Petr Skoda added a comment -

            grrrrr, wrong dir, I looked at spikephpcoverage....

            Show
            skodak Petr Skoda added a comment - grrrrr, wrong dir, I looked at spikephpcoverage....
            Hide
            skodak Petr Skoda added a comment -

            thanks for the report

            Show
            skodak Petr Skoda added a comment - thanks for the report
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! 2.2 release docs updated to add this.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! 2.2 release docs updated to add this.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Pass

            Show
            samhemelryk Sam Hemelryk added a comment - Pass
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Done, your delicious hacks have been sent upstream, many thanks!

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Done, your delicious hacks have been sent upstream, many thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/11