Moodle
  1. Moodle
  2. MDL-29924

Glossary attachments are not added to filter popups

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 2.0.5, 2.1.2
        • Fix Version/s: 2.1.7, 2.2.4
        • Component/s: Blocks, Filters, Glossary
        • Labels:
          None
        • Testing Instructions:
          Hide

          Activate glossary filter on system level,
          Create a course glossary and an entry with an attachment.
          Create a text field entry with the text of the glossary entry title. Save entry.
          Click on the linked text on course page to open the glossary entry

          Show
          Activate glossary filter on system level, Create a course glossary and an entry with an attachment. Create a text field entry with the text of the glossary entry title. Save entry. Click on the linked text on course page to open the glossary entry
        • Affected Branches:
          MOODLE_20_STABLE, MOODLE_21_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-29924-master
        • Pull Master Diff URL:
        • Rank:
          19458

          Description

          In Moodle 1.9 the popup window of glossary entries showed the content and the attachments from a glossary entry. In Moodle 2 the attachment is not shown in the popup.
          Same problem if you click on the glossary link in glossary block. The popup window don't shows attachment.

          The bug is categorized as critical because its a feature that is available in 1.9 and former versions but missing in 2.x without any notifications or documentation.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Changes look spot on thanks Fred, feel free to put this up for integration when you are ready.

            Show
            Sam Hemelryk added a comment - Changes look spot on thanks Fred, feel free to put this up for integration when you are ready.
            Hide
            Permalink
            Dan Poltawski added a comment -

            Thanks Fred, i've integrated this now

            Show
            Dan Poltawski added a comment - Thanks Fred, i've integrated this now
            Hide
            Permalink
            Jason Fowler added a comment -

            looks fine thanks Fred

            Show
            Jason Fowler added a comment - looks fine thanks Fred
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: