Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29960

Dropbox repository not functioning

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      1. New Moodle 2.1 install
      2. Enable Dropbox repository
      3. Insert both keys
      – so far, so good –
      4. Create new course
      5. Add a file from Dropbox inside that course

      Show
      1. New Moodle 2.1 install 2. Enable Dropbox repository 3. Insert both keys – so far, so good – 4. Create new course 5. Add a file from Dropbox inside that course
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      dropbox-api-bump-for-master

      Description

      Tried to enable Dropbox repository for Moodle 2 (entered both keys) and everything seemed OK. But when I tried to add a file inside the course and tried to use a file from Dropbox I got the following error: "You're using an older version of the Dropbox API with a new API key. Please use the latest version."

        Gliffy Diagrams

          Activity

          Hide
          izendegi Iñigo Zendegi added a comment -

          It seems that Dropbox has updated the API and Moodle has to be updated to be able to work with the apps created with this new API:

          http://forums.dropbox.com/topic.php?id=47381&replies=2#post-363699

          Show
          izendegi Iñigo Zendegi added a comment - It seems that Dropbox has updated the API and Moodle has to be updated to be able to work with the apps created with this new API: http://forums.dropbox.com/topic.php?id=47381&replies=2#post-363699
          Hide
          dougiamas Martin Dougiamas added a comment -

          Confirmed. Dropbox is non-functional for Moodle now.

          Dongsheng is unable to work on this right now. Any volunteers?

          Show
          dougiamas Martin Dougiamas added a comment - Confirmed. Dropbox is non-functional for Moodle now. Dongsheng is unable to work on this right now. Any volunteers?
          Hide
          dougiamas Martin Dougiamas added a comment - - edited
          Show
          dougiamas Martin Dougiamas added a comment - - edited The new API is announced here: http://forums.dropbox.com/topic.php?id=46501&replies=32 and described here: https://www.dropbox.com/developers
          Hide
          dougiamas Martin Dougiamas added a comment -

          Pinging Dan. Is there any chance you could look into this for us? (reassign back to moodle.com if not! )

          Show
          dougiamas Martin Dougiamas added a comment - Pinging Dan. Is there any chance you could look into this for us? (reassign back to moodle.com if not! )
          Hide
          poltawski Dan Poltawski added a comment -

          The good news is that old API keys are still working with the older version of the API so this is not currently breaking sites which had already linked to dropbox.

          The bad news is i'm not sure yet if those keys will work with the new version of the API for the upgrade to fix..

          Show
          poltawski Dan Poltawski added a comment - The good news is that old API keys are still working with the older version of the API so this is not currently breaking sites which had already linked to dropbox. The bad news is i'm not sure yet if those keys will work with the new version of the API for the upgrade to fix..
          Hide
          poltawski Dan Poltawski added a comment -

          OK, so i've gone for the fairly straight forward fixes to this where it just needs API url updates.

          In master I also removed some obsolete code.

          However, longer term, dropbox are encouraging app folder type access rather than full access to the dropbox folder - this is fairly straight forward to achieve but I didn't want to change it at this late stage.

          Show
          poltawski Dan Poltawski added a comment - OK, so i've gone for the fairly straight forward fixes to this where it just needs API url updates. In master I also removed some obsolete code. However, longer term, dropbox are encouraging app folder type access rather than full access to the dropbox folder - this is fairly straight forward to achieve but I didn't want to change it at this late stage.
          Hide
          poltawski Dan Poltawski added a comment -

          Just to comment on ' i'm not sure yet if those keys will work with the new version of the API for the upgrade to fix..', I have tested this and they do.

          To confirm I have tested:
          1/ One newly created api key created today
          2/ One months old api key created before API1.0 came out
          3/ One oldish api key

          Show
          poltawski Dan Poltawski added a comment - Just to comment on ' i'm not sure yet if those keys will work with the new version of the API for the upgrade to fix..', I have tested this and they do. To confirm I have tested: 1/ One newly created api key created today 2/ One months old api key created before API1.0 came out 3/ One oldish api key
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated into 20 and 21 stable before rolling releases... (will integrate into master after that).

          Yes, I think we need to move to the new API allowing application folders / full access ASAP. Would be great to have one issue about that...

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated into 20 and 21 stable before rolling releases... (will integrate into master after that). Yes, I think we need to move to the new API allowing application folders / full access ASAP. Would be great to have one issue about that...
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Tested under 20 and 21 with new key + tests by Dan with old ones. Seems to work. Passing.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Tested under 20 and 21 with new key + tests by Dan with old ones. Seems to work. Passing.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          master integrated too. Thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - master integrated too. Thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          (and tested it's woking now with new API keys)

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - (and tested it's woking now with new API keys)
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Landed on time, yay. Thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Landed on time, yay. Thanks!
          Hide
          dougiamas Martin Dougiamas added a comment -

          Fantastic, bloody awesome, thanks Dan!

          Show
          dougiamas Martin Dougiamas added a comment - Fantastic, bloody awesome, thanks Dan!

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                28/Nov/11