Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29965

decrease amount of padding in SCORM new window

          Details

          • Type: Improvement
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.1
          • Fix Version/s: 2.1.3
          • Component/s: SCORM
          • Labels:
          • Testing Instructions:
            Hide

            Enter a SCORM in normal mode using the setting current window - (happens on first time you enter package anyway)
            check to see if player window lines up with top of blocks on left.
            Enter a SCORM in normal mode using the setting "new window" - check to make sure player doesn't have 40px of wasted space above the player

            Show
            Enter a SCORM in normal mode using the setting current window - (happens on first time you enter package anyway) check to see if player window lines up with top of blocks on left. Enter a SCORM in normal mode using the setting "new window" - check to make sure player doesn't have 40px of wasted space above the player
          • Affected Branches:
            MOODLE_21_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            master_MDL-29965
          • Pull Master Diff URL:

            Description

            there's a bunch of padding in the display of SCORM packages which are a pain when working with new windows.

            we need to improve this a bit.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  danmarsden Dan Marsden added a comment -

                  This patch removes the 10px padding around the box and only displays the scormtop div if it contains something - saving 40px of space at the top of the player.

                  Show
                  danmarsden Dan Marsden added a comment - This patch removes the 10px padding around the box and only displays the scormtop div if it contains something - saving 40px of space at the top of the player.
                  Hide
                  Permalink
                  danmarsden Dan Marsden added a comment -

                  Note to integrator - this is intentionally only for 2.1Stable and master.

                  Show
                  danmarsden Dan Marsden added a comment - Note to integrator - this is intentionally only for 2.1Stable and master.
                  Hide
                  Permalink
                  danmarsden Dan Marsden added a comment -

                  there are probably other improvements that can be done to the layout of the SCORM player - this just makes a few quick easy improvements to decrease wasted space.

                  Show
                  danmarsden Dan Marsden added a comment - there are probably other improvements that can be done to the layout of the SCORM player - this just makes a few quick easy improvements to decrease wasted space.
                  Hide
                  Permalink
                  wisedave Dave Newgass added a comment -

                  Another one to watch....cheers

                  Dave

                  Show
                  wisedave Dave Newgass added a comment - Another one to watch....cheers Dave
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Spot on thanks Dan - this has been integrated now

                  Show
                  samhemelryk Sam Hemelryk added a comment - Spot on thanks Dan - this has been integrated now
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment -

                  This is working great.

                  Test passed.

                  Show
                  rwijaya Rossiani Wijaya added a comment - This is working great. Test passed.
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  And this has been sent upstream (already available @ git and cvs repos). Many, many thanks!

                  Closing as fixed, ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - And this has been sent upstream (already available @ git and cvs repos). Many, many thanks! Closing as fixed, ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      4 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        28/Nov/11