Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29966

404 for i/ajaxloader image - wrong variable order in function call

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.5, 2.1.2, 2.2
          • Fix Version/s: 2.0.6, 2.1.3
          • Component/s: Groups
          • Labels:
            None
          • Testing Instructions:
            Hide

            1/ go to groups page
            2/ click on group in left column
            3/ there should be a spinning thing above the right column with users (you may have to slow somehow your browser, I hacked in one js alert to make it pause a bit when testing it)

            Show
            1/ go to groups page 2/ click on group in left column 3/ there should be a spinning thing above the right column with users (you may have to slow somehow your browser, I hacked in one js alert to make it pause a bit when testing it)
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            w43_MDL-29966_m22_grouploading
          • Pull Master Diff URL:

            Description

            In /group/clientlib.js, line 186
            replace
            loadingImg.setAttribute("src", M.util.image_url('moodle', '/i/ajaxloader'));
            with
            loadingImg.setAttribute("src", M.util.image_url('/i/ajaxloader', 'moodle'));

            Variables are supplied to the function in wrong order, the result is that the image isn't found (404 in apache log)

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  skodak Petr Skoda added a comment -

                  thanks for the report and patch!

                  Show
                  skodak Petr Skoda added a comment - thanks for the report and patch!
                  Hide
                  Permalink
                  nebgor Aparup Banerjee added a comment -

                  awesome, thats been integrated.

                  Show
                  nebgor Aparup Banerjee added a comment - awesome, thats been integrated.
                  Hide
                  Permalink
                  ankit_frenz Ankit Agarwal added a comment -

                  I can see the spinning sun!
                  Test passed!
                  Thanks

                  Show
                  ankit_frenz Ankit Agarwal added a comment - I can see the spinning sun! Test passed! Thanks
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  And this has been sent upstream (already available @ git and cvs repos). Many, many thanks!

                  Closing as fixed, ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - And this has been sent upstream (already available @ git and cvs repos). Many, many thanks! Closing as fixed, ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        28/Nov/11