Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29980

MP3 Flow Player doesn't work in Chrome if colours are specified in CSS

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.2, 2.2
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Filters, Libraries
    • Labels:
      None
    • Testing Instructions:
      Hide

      1/ modify filter/mediaplugin/styles.css .mp3flowplayer_backgroundColor {color: #ff0000;}
      2/ disable caching or reset
      3/ add page that links to mp3 file
      4/ test supported browsers - all should show red background

      Show
      1/ modify filter/mediaplugin/styles.css .mp3flowplayer_backgroundColor {color: #ff0000;} 2/ disable caching or reset 3/ add page that links to mp3 file 4/ test supported browsers - all should show red background
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w43_MDL-29980_m22_flowcss

      Description

      If any CSS rules are defined to specify MP3 Flow Player colours, the MP3 Flow Player will not appear at all in Chrome (and possibly other browsers). The master branch fixed a typo in filter/mediaplugin/styles.css which triggers this issue. The fix is dead simple (hence the lack of pull details - it's not worth the effort!):

      lib/javascript-static.js, lines 1694-1698 currently read:

      if (typeof(allrules[i].cssText) != 'undefined') {
          rule = allrules[i].style.cssText;
      } else if (typeof(allrules[i].style.cssText) != 'undefined') {
          rule = allrules[i].style.cssText;
      }

      Change line 1695 (second line above) to read:

      rule = allrules[i].cssText;

      (remove the "style.") and all will be well with the world again (or at least with the MP3 Flow Player).

      (sorry for the edits, the tracker's not playing nice with the block of code)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Petr - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Petr - this has been integrated now
            Hide
            phalacee Jason Fowler added a comment -

            Works fine

            Show
            phalacee Jason Fowler added a comment - Works fine
            Hide
            phalacee Jason Fowler added a comment -

            although the player still doesn't play ...

            Show
            phalacee Jason Fowler added a comment - although the player still doesn't play ...
            Hide
            nebgor Aparup Banerjee added a comment -

            this works or me (in bright red too :-D ) , not sure why its not playing for Jason.

            Show
            nebgor Aparup Banerjee added a comment - this works or me (in bright red too :-D ) , not sure why its not playing for Jason.
            Hide
            nebgor Aparup Banerjee added a comment -

            Jason, do remember to hit 'purge caches' at the bottom of the page during testing css.

            Show
            nebgor Aparup Banerjee added a comment - Jason, do remember to hit 'purge caches' at the bottom of the page during testing css.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Re-tested this issue and it works.

            Some note while testing this, sometimes the page needs to be refreshed couple of times before flowplayer appeared. I will create new issue, just in-case other user experiencing the same behavior (MDL-30030).

            I'm passing this test.

            Show
            rwijaya Rossiani Wijaya added a comment - Re-tested this issue and it works. Some note while testing this, sometimes the page needs to be refreshed couple of times before flowplayer appeared. I will create new issue, just in-case other user experiencing the same behavior ( MDL-30030 ). I'm passing this test.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this has been sent upstream (already available @ git and cvs repos). Many, many thanks!

            Closing as fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this has been sent upstream (already available @ git and cvs repos). Many, many thanks! Closing as fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  28/Nov/11