Moodle
  1. Moodle
  2. MDL-29993

Convert the mod/data legacy filter to 2.0 one

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Filters
    • Labels:
      None
    • Testing Instructions:
      Hide

      NOTE: Testing this requires access to integration.git to switch/install from different branches.

      1) Install Moodle 2.1

      2) Enable the data filter @ admin (off but available) and set "Text cache lifetime" = No

      3a) Create one new course, one data activity (name and description, of type text and textarea, with the name linking option checked). Add 2-3 records.

      3b) Create one data activity @ front page (also name and description, with the name linking option checked). Add 2-3 records.

      4) Create one paragraph of text containing those words (name field).

      5) Put he paragraph in various places:

      • One forum post in the same course
      • One forum post in another course
      • One label in own course
      • One label in front page
      • In the own course intro
      • In own course category description

      6) TEST: Initially those words won't be linked (because @ 1) we have added the filter but off by default).

      7) Enable the data filter in the 6 places where you have created the paragraph. It's not important if the links start to work or no, some of them will and others won't you can ignore it in 2.1.

      8) Verify that there are 7 records in the filter_active table with mod/data

      9) Upgrade to master (integration.git)

      10) Verify that there are 7 records in the filter_active table with filter/data and 0 with the old mod/data

      11) Verify that the links to the records work as expected, with the 6 places linking properly to the record. Note that the records added to the course (3a) only will be linked from within the course, and not at category or frontpage contexts. In the other side the records added to the frontpage activity should be linked from everywhere (they are sort of global).

      12) Play disabling and enabling the filter at different contexts, filter does its job accordingly.

      Show
      NOTE: Testing this requires access to integration.git to switch/install from different branches. 1) Install Moodle 2.1 2) Enable the data filter @ admin (off but available) and set "Text cache lifetime" = No 3a) Create one new course, one data activity (name and description, of type text and textarea, with the name linking option checked). Add 2-3 records. 3b) Create one data activity @ front page (also name and description, with the name linking option checked). Add 2-3 records. 4) Create one paragraph of text containing those words (name field). 5) Put he paragraph in various places: One forum post in the same course One forum post in another course One label in own course One label in front page In the own course intro In own course category description 6) TEST: Initially those words won't be linked (because @ 1) we have added the filter but off by default). 7) Enable the data filter in the 6 places where you have created the paragraph. It's not important if the links start to work or no, some of them will and others won't you can ignore it in 2.1. 8) Verify that there are 7 records in the filter_active table with mod/data 9) Upgrade to master (integration.git) 10) Verify that there are 7 records in the filter_active table with filter/data and 0 with the old mod/data 11) Verify that the links to the records work as expected, with the 6 places linking properly to the record. Note that the records added to the course (3a) only will be linked from within the course, and not at category or frontpage contexts. In the other side the records added to the frontpage activity should be linked from everywhere (they are sort of global). 12) Play disabling and enabling the filter at different contexts, filter does its job accordingly.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19537

      Description

      While we have been supporting legacy filters and legacy locations till 2.2, it's time convert the legacy core data filter to proper one. That will:

      • fix problems like MDL-27961
      • allow to deprecate, ban and cleanup (along 2.2, 2.3 and 2.4) all the old filters stuff

      Ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending to integration, yay!

          Show
          Eloy Lafuente (stronk7) added a comment - Sending to integration, yay!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Note to integrators, this must be integrated after MDL-29978 because contains plugin dependencies stuff fixed by it.

          Show
          Eloy Lafuente (stronk7) added a comment - Note to integrators, this must be integrated after MDL-29978 because contains plugin dependencies stuff fixed by it.
          Hide
          Sam Hemelryk added a comment -

          Thanks Eloy this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Eloy this has been integrated now
          Hide
          Aparup Banerjee added a comment -

          this works for me - passed

          Show
          Aparup Banerjee added a comment - this works for me - passed
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been sent upstream (already available @ git and cvs repos). Many, many thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been sent upstream (already available @ git and cvs repos). Many, many thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: