Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29994

Prevent mod/glossary and mod/data filters to be installed anymore

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Filters
    • Labels:
      None
    • Testing Instructions:
      Hide

      This requires access to the DB and to codebase:

      A) Upgrade from Moodle 2.1 to master (integration.git).

      1) Go to admin->plugins->filters.

      2) Verify you can see there the glossary and data filters.

      3) Verify that the filter_active table contains record(s) for filter/glossary and filter/data (but not for mod/glossary and mod/data).

      4) Verify that mod/glossary/filter.php and mod/data/filter.php do not exist.

      5) Create mod/forum/filter.php (any content).

      6) Verify that one new row is shown in admin->plugins->filters (in red, unnamed but related with mod/forum).

      7) Verify that one new record in the filter_active table for the just created mod/forum filter.

      8) Delete the file mod/forum/filter.php and the record in filter_active for mod/forum.

      9) Verify that admin->plugins->filters is back to normal (no mod/forum shown anymore).

      10) Create mod/data/filter.php and mod/data/glossary.php (any content).

      11) Verify that the 2 new created filters are not shown in admin->plugins->filters.

      12) Verify that there are no records in filter_active corresponding to mod/data and mod/glossary (but the filter/data and filter/glossary ones remains).

      13) Delete the mod/data/filter.php and mod/data/glossary.php files.

      B) Repeat steps 1-13 into a installed master (2.2) site.

      Show
      This requires access to the DB and to codebase: A) Upgrade from Moodle 2.1 to master (integration.git). 1) Go to admin->plugins->filters. 2) Verify you can see there the glossary and data filters. 3) Verify that the filter_active table contains record(s) for filter/glossary and filter/data (but not for mod/glossary and mod/data). 4) Verify that mod/glossary/filter.php and mod/data/filter.php do not exist. 5) Create mod/forum/filter.php (any content). 6) Verify that one new row is shown in admin->plugins->filters (in red, unnamed but related with mod/forum). 7) Verify that one new record in the filter_active table for the just created mod/forum filter. 8) Delete the file mod/forum/filter.php and the record in filter_active for mod/forum. 9) Verify that admin->plugins->filters is back to normal (no mod/forum shown anymore). 10) Create mod/data/filter.php and mod/data/glossary.php (any content). 11) Verify that the 2 new created filters are not shown in admin->plugins->filters. 12) Verify that there are no records in filter_active corresponding to mod/data and mod/glossary (but the filter/data and filter/glossary ones remains). 13) Delete the mod/data/filter.php and mod/data/glossary.php files. B) Repeat steps 1-13 into a installed master (2.2) site.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Once we have both the new glossary and data filters working, if may possible to reinstall the legacy ones again (by manually putting the old files in place).

      But we want to prevent this because there are various problems having them working together (admin/filters.php mess, double processing issues...).

      So this issue is about to prevent (harcoded) the possibility of reinstalling those filters again. Note it won't prevent other mod/xxxx contrib filters to be installed for now. Just the core ones.

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29992 Convert the mod/glossary legacy filter to 2.0 one

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29993 Convert the mod/data legacy filter to 2.0 one

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-29995 Mark all the legacy filters support as deprecated for 2.2

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Integrator:
              Sam Hemelryk
              Tester:
              Aparup Banerjee
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11