Moodle
  1. Moodle
  2. MDL-29998

Refactor filters a bit once support for legacy filters and locations have been performed

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Duplicate
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Filters
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE
    • Rank:
      19542

      Description

      In 2.2 we marked all legacy filters and locations as deprecated (see MDL-29995 and release notes). And in 2.3 support for them has been dropped (see MDL-29996).

      So now it's safe to improve the filters plugin type to start using proper component names here and there. This issue is about to collect and perform the needed changes.

      Note that while it was originally planned for 2.4 (see comment @ MDL-27961) it's highly possible to do it for 2.3 (once MDL-29996 has been done), so I'm pointing to it as target.

      Ciao

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Note for me, unrelated but here to forget:

          Also, look for get_config() uses looking for wrong component names (like auth/xxx and so on). Migrate all the uses and all the information in DB. Look if there is already one issue for that, creating it if necessary. Discovered while checking some get_config() uses @ MDL-31006

          This regexp will show a bunch of them:

          grep -r '[^>:]get_config(.*\/.*)' *
          

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Note for me, unrelated but here to forget: Also, look for get_config() uses looking for wrong component names (like auth/xxx and so on). Migrate all the uses and all the information in DB. Look if there is already one issue for that, creating it if necessary. Discovered while checking some get_config() uses @ MDL-31006 This regexp will show a bunch of them: grep -r '[^>:]get_config(.*\/.*)' * Ciao
          Hide
          Petr Škoda added a comment -

          The linked issue already contains the refactoring, thanks for the report.

          Show
          Petr Škoda added a comment - The linked issue already contains the refactoring, thanks for the report.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: