Moodle
  1. Moodle
  2. MDL-30003

Code Errors when running student's Statistics

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4
    • Fix Version/s: 2.1.5
    • Component/s: General
    • Labels:
      None
    • Environment:
      2.1.2+ (Build: 20111012), PHP Version 5.3.6, MySQL 5.1.57.
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1/ enable stats on site that have enough logged data (at least a month)
      2/ execute cron to process stats (this may be tricky too ebcause it is allowed only once a day at specific time)
      3/ execute the report - depending on your data you may not get the notice even in current code, so only make sure the earliest date is only

      Show
      1/ enable stats on site that have enough logged data (at least a month) 2/ execute cron to process stats (this may be tricky too ebcause it is allowed only once a day at specific time) 3/ execute the report - depending on your data you may not get the notice even in current code, so only make sure the earliest date is only
    • Workaround:
      Hide

      None.

      Show
      None.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      19547

      Description

      When I run statistics for a student, the report shows code errors (see attachment). On my Moodle, I have turn "Show Debug Messages" on. I am not sure if those who don't turn this on will see these errors.

      It appears that the statistics run, but I wonder if they are correct because there seems to be some errors showing.

        Activity

        Hide
        Sam Marshall added a comment -

        Not related to activity completion, so reassigning away from me. There doesn't seem to be a 'statistics' category or 'logs' or 'reports', so I just chose 'general', apologies if this is not the best one.

        Show
        Sam Marshall added a comment - Not related to activity completion, so reassigning away from me. There doesn't seem to be a 'statistics' category or 'logs' or 'reports', so I just chose 'general', apologies if this is not the best one.
        Hide
        Petr Škoda added a comment -

        Thanks for the report, in the middle of fixing I discovered it is already fixed in Moodle 2.2x, normally we would not probably fix small issues like this in older stable branches, but I already made the patch, hopefully integrators will accept it...

        Ciao

        Show
        Petr Škoda added a comment - Thanks for the report, in the middle of fixing I discovered it is already fixed in Moodle 2.2x, normally we would not probably fix small issues like this in older stable branches, but I already made the patch, hopefully integrators will accept it... Ciao
        Hide
        Aparup Banerjee added a comment -

        thanks, this has been integrated.

        Show
        Aparup Banerjee added a comment - thanks, this has been integrated.
        Hide
        Rossiani Wijaya added a comment -

        I don't have user statistic data available for my site. However, I didn't get any error for accessing the statistics report.

        Looking at the patch, I would say it passed the test.

        Second opinion regarding this would be great.

        Show
        Rossiani Wijaya added a comment - I don't have user statistic data available for my site. However, I didn't get any error for accessing the statistics report. Looking at the patch, I would say it passed the test. Second opinion regarding this would be great.
        Hide
        Aparup Banerjee added a comment -

        Hi Rick, could you help verify that this works fine for you?

        Show
        Aparup Banerjee added a comment - Hi Rick, could you help verify that this works fine for you?
        Hide
        Eloy Lafuente (stronk7) added a comment -

        I'm passing this, in order to roll weeklies now. The change looks perfect to fix that problem. Any confirmation will be welcome, anyway, TIA.

        Show
        Eloy Lafuente (stronk7) added a comment - I'm passing this, in order to roll weeklies now. The change looks perfect to fix that problem. Any confirmation will be welcome, anyway, TIA.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now available in the git and cvs repositories.

        Consider the responsibility of your fingerprints engraved there for future generations!

        Thanks for the work, closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao
        Hide
        Rick Jerz added a comment -

        Aparup asked me to verify that this fix is working. However, when I went back to check on this I discovered that I cannot get statistics working. I have not made any changes to the settings. I, however, did upgrade my Moodle since my original post. I am now at Moodle 2.2.1 (Build: 20120109). In the discussion forums, I see that others are encountering the same problem that I have encountered - statistics mysteriously not working. Any ideas? I messes around with the timing for statistics and got the following message. Must backup be enabled for statistics to work?

        Checking automated backup status...INACTIVE
        ...preventing stats to run, last execution was less than 20 hours ago.
        Deleting old draft files... done.
        Cron script completed correctly
        Execution took 0.546713 seconds

        Show
        Rick Jerz added a comment - Aparup asked me to verify that this fix is working. However, when I went back to check on this I discovered that I cannot get statistics working. I have not made any changes to the settings. I, however, did upgrade my Moodle since my original post. I am now at Moodle 2.2.1 (Build: 20120109). In the discussion forums, I see that others are encountering the same problem that I have encountered - statistics mysteriously not working. Any ideas? I messes around with the timing for statistics and got the following message. Must backup be enabled for statistics to work? Checking automated backup status...INACTIVE ...preventing stats to run, last execution was less than 20 hours ago. Deleting old draft files... done. Cron script completed correctly Execution took 0.546713 seconds
        Hide
        Rick Jerz added a comment -

        I just upgraded to Moodle 2.2.1+ (Build: 20120119). I am unable to see statistics, so I created another bug report at MDL-31325. Sorry that I can't help because I have encountered another problem. I will do my best to keep you informed on my progress.

        Show
        Rick Jerz added a comment - I just upgraded to Moodle 2.2.1+ (Build: 20120119). I am unable to see statistics, so I created another bug report at MDL-31325 . Sorry that I can't help because I have encountered another problem. I will do my best to keep you informed on my progress.
        Hide
        Petr Škoda added a comment -

        Hello, I have just tested the stats and reviewed code - it works fine for me and there was no change in 2.2.

        Show
        Petr Škoda added a comment - Hello, I have just tested the stats and reviewed code - it works fine for me and there was no change in 2.2.
        Hide
        Rick Jerz added a comment -

        I am eager to get my statistics working so that I can test this fix. Thanks.

        Show
        Rick Jerz added a comment - I am eager to get my statistics working so that I can test this fix. Thanks.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: