Moodle
  1. Moodle
  2. MDL-30021

Better default when importing numerical questions from Moodle 1.9

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.1.3
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1) In a Moodle 1.9 site, create a course with a quiz and two numerical questions in its question bank.
      question a) A numerical question with no units.
      question b) A numerical question with some units.
      question c) A calculated question with no units.
      question d) A calculated question with some units.

      2) Backup the 1.9 course, and restore into Moodle 2.1+. Verify that:

      • question a) is set to Unit handling: "Units are not used at all. Only the numerical value is graded."
      • question b) is set to Unit handling: "Units are optional. If a unit is entered, it is used to convert the reponse to Unit 1 before grading."
      • similarly for c) and d)

      3) Export the questions from Moodle 1.9 using Moodle XML format. Import into Moodle 2.1+. Verify the same thing as before.

      4) Upgrade the site to Moodle 2.1+. Verify the same thing as before.

      Show
      1) In a Moodle 1.9 site, create a course with a quiz and two numerical questions in its question bank. question a) A numerical question with no units. question b) A numerical question with some units. question c) A calculated question with no units. question d) A calculated question with some units. 2) Backup the 1.9 course, and restore into Moodle 2.1+. Verify that: question a) is set to Unit handling: "Units are not used at all. Only the numerical value is graded." question b) is set to Unit handling: "Units are optional. If a unit is entered, it is used to convert the reponse to Unit 1 before grading." similarly for c) and d) 3) Export the questions from Moodle 1.9 using Moodle XML format. Import into Moodle 2.1+. Verify the same thing as before. 4) Upgrade the site to Moodle 2.1+. Verify the same thing as before.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19564

      Description

      We can look at whether there are any units defined before setting the unit handling setting to a default. This logic is already used on upgrade. We need to make sure it is used on backup and restore.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Actually, this logic is not used on upgrade. I will add it.

          Show
          Tim Hunt added a comment - Actually, this logic is not used on upgrade. I will add it.
          Hide
          Tim Hunt added a comment -

          This also applies to calculated qtype

          Show
          Tim Hunt added a comment - This also applies to calculated qtype
          Hide
          Tim Hunt added a comment -

          Note to integrators, please integrate MDL-29739 and MDL-29058 first (in that order)

          Show
          Tim Hunt added a comment - Note to integrators, please integrate MDL-29739 and MDL-29058 first (in that order)
          Hide
          Rajesh Taneja added a comment -

          Code looks Great to me Tim

          Show
          Rajesh Taneja added a comment - Code looks Great to me Tim
          Hide
          Aparup Banerjee added a comment - - edited

          Thanks, this has been integrated and is up for testing. (and thats the whole string of related issues integrated)

          Show
          Aparup Banerjee added a comment - - edited Thanks, this has been integrated and is up for testing. (and thats the whole string of related issues integrated)
          Hide
          Ankit Agarwal added a comment -

          Works awesome
          All tests passed!
          Thanks!

          Show
          Ankit Agarwal added a comment - Works awesome All tests passed! Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: