Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30031

Adaptive mode should ignore invalid answers without penalty

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Preparation:

      • Create a quiz with the following setting:
        • Title: "Adaptive Test"
        • How questions behave: Adaptive mode
      • Create a question with the following settings, and add it to the quiz:
        • Type: Numerical
        • Question text: "What is 2+2?"
        • Answer: 4 (Grade 100%)
      • Duplicate the quiz, and change settings in the copy as follows:
        • Title: "AdaptiveNoPenalty Test"
        • How questions behave: Adaptive (no penalties)

      Test script 1:

      • Preview the quiz "Adaptive test"
      • As the answer, enter "four", and click "Check".

      VERIFY: The following two messages are displayed:
      "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty"

      • As the answer, enter "4", and click "Check"

      VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

      • Click "Next", then "Submit all and finish".

      VERIFY: Total marks given for the quiz attempt are 1.00/1.00.

      Test script 2:

      • Preview the quiz "AdaptiveNoPenalties test"
      • As the answer, enter "four", and click "Check".

      VERIFY: The following message is displayed (but none beyond this):
      "You must enter a valid number"

      • As the answer, enter "4", and click "Check"

      VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

      Test script 3:

      Run all the unit tests in path "question".

      Show
      Preparation: Create a quiz with the following setting: Title: "Adaptive Test" How questions behave: Adaptive mode Create a question with the following settings, and add it to the quiz: Type: Numerical Question text: "What is 2+2?" Answer: 4 (Grade 100%) Duplicate the quiz, and change settings in the copy as follows: Title: "AdaptiveNoPenalty Test" How questions behave: Adaptive (no penalties) Test script 1: Preview the quiz "Adaptive test" As the answer, enter "four", and click "Check". VERIFY: The following two messages are displayed: "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty" As the answer, enter "4", and click "Check" VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00." Click "Next", then "Submit all and finish". VERIFY: Total marks given for the quiz attempt are 1.00/1.00. Test script 2: Preview the quiz "AdaptiveNoPenalties test" As the answer, enter "four", and click "Check". VERIFY: The following message is displayed (but none beyond this): "You must enter a valid number" As the answer, enter "4", and click "Check" VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00." Test script 3: Run all the unit tests in path "question".
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Quizzes in adaptive mode should ignore invalid answers to a question (e.g., non-numerical answers to numerical questions) without applying a penalty.

      This currently works with numerical questions in interactive mode, but fails with numerical questions in adaptive mode. (Other combinations not yet tested.)

      See http://moodle.org/mod/forum/discuss.php?d=189276

        Gliffy Diagrams

          Attachments

            Activity

            bostelm Henning Bostelmann created issue -
            bostelm Henning Bostelmann made changes -
            Field Original Value New Value
            Assignee Tim Hunt [ timhunt ] Henning Bostelmann [ bostelm ]
            timhunt Tim Hunt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels triaged
            bostelm Henning Bostelmann made changes -
            Pull Master Diff URL https://github.com/bostelm/moodle/compare/master...MDL-30031
            Pull Master Branch MDL-30031
            Testing Instructions * Create a quiz with the following setting:
            ** How questions behave: Adaptive mode
            * Create a question with the following settings, and add it to the quiz:
            ** Type: Numerical
            ** Question text: "What is 2+2?"
            ** Answer: 4 (Grade 100%)
            * Preview the quiz
            * As the answer, enter "four", and click "Check".

            VERIFY: The following two messages are displayed:
            "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty"

            * As the answer, enter "4", and click "Check"

            VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

            * Click "Next", then "Submit all and finish".

            VERIFY: Total marks given for the quiz attempt are 1.00/1.00.
            Pull from Repository git://github.com/bostelm/moodle
            timhunt Tim Hunt made changes -
            Status Open [ 1 ] Peer review in progress [ 10013 ]
            Peer reviewer timhunt
            timhunt Tim Hunt made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            timhunt Tim Hunt made changes -
            Testing Instructions * Create a quiz with the following setting:
            ** How questions behave: Adaptive mode
            * Create a question with the following settings, and add it to the quiz:
            ** Type: Numerical
            ** Question text: "What is 2+2?"
            ** Answer: 4 (Grade 100%)
            * Preview the quiz
            * As the answer, enter "four", and click "Check".

            VERIFY: The following two messages are displayed:
            "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty"

            * As the answer, enter "4", and click "Check"

            VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

            * Click "Next", then "Submit all and finish".

            VERIFY: Total marks given for the quiz attempt are 1.00/1.00.
            * Create a quiz with the following setting:
            ** How questions behave: Adaptive mode
            * Create a question with the following settings, and add it to the quiz:
            ** Type: Numerical
            ** Question text: "What is 2+2?"
            ** Answer: 4 (Grade 100%)
            * Preview the quiz
            * As the answer, enter "four", and click "Check".

            VERIFY: The following two messages are displayed:
            "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty"

            * As the answer, enter "4", and click "Check"

            VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

            * Click "Next", then "Submit all and finish".

            VERIFY: Total marks given for the quiz attempt are 1.00/1.00.


            ... some similar test using Adaptive (no penalty) ... behaviour


            Also, run all the unit tests in question.
            bostelm Henning Bostelmann made changes -
            Testing Instructions * Create a quiz with the following setting:
            ** How questions behave: Adaptive mode
            * Create a question with the following settings, and add it to the quiz:
            ** Type: Numerical
            ** Question text: "What is 2+2?"
            ** Answer: 4 (Grade 100%)
            * Preview the quiz
            * As the answer, enter "four", and click "Check".

            VERIFY: The following two messages are displayed:
            "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty"

            * As the answer, enter "4", and click "Check"

            VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

            * Click "Next", then "Submit all and finish".

            VERIFY: Total marks given for the quiz attempt are 1.00/1.00.


            ... some similar test using Adaptive (no penalty) ... behaviour


            Also, run all the unit tests in question.
            Preparation:

            * Create a quiz with the following setting:
            ** Title: "Adaptive Test"
            ** How questions behave: Adaptive mode
            * Create a question with the following settings, and add it to the quiz:
            ** Type: Numerical
            ** Question text: "What is 2+2?"
            ** Answer: 4 (Grade 100%)
            * Duplicate the quiz, and change settings in the copy as follows:
            ** Title: "AdaptiveNoPenalty Test"
            ** How questions behave: Adaptive (no penalties)

            Test script 1:

            * Preview the quiz "Adaptive test"
            * As the answer, enter "four", and click "Check".

            VERIFY: The following two messages are displayed:
            "You must enter a valid number"; "The submission was invalid, and has been disregarded without penalty"

            * As the answer, enter "4", and click "Check"

            VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

            * Click "Next", then "Submit all and finish".

            VERIFY: Total marks given for the quiz attempt are 1.00/1.00.

            Test script 2:

            * Preview the quiz "AdaptiveNoPenalties test"
            * As the answer, enter "four", and click "Check".

            VERIFY: The following message is displayed (but none beyond this):
            "You must enter a valid number"

            * As the answer, enter "4", and click "Check"

            VERIFY: The following message is displayed: "Correct. Marks for this submission: 1.00/1.00."

            Test script 3:

            Run all the unit tests in path "question".
            Pull 2.2 Diff URL https://github.com/bostelm/moodle/compare/MOODLE_22_STABLE...MDL-30031-22
            Pull 2.1 Branch MDL-30031-21
            Pull 2.2 Branch MDL-30031-22
            Pull 2.1 Diff URL https://github.com/bostelm/moodle/compare/MOODLE_21_STABLE...MDL-30031-21
            bostelm Henning Bostelmann made changes -
            Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
            timhunt Tim Hunt made changes -
            Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
            Fix Version/s 2.1.4 [ 11452 ]
            Fix Version/s 2.2.1 [ 11456 ]
            Fix Version/s 2.3 [ 10657 ]
            Fix Version/s STABLE backlog [ 10463 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator stronk7
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for integration review [ 10010 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.2.2 [ 11552 ]
            Fix Version/s 2.2.1 [ 11456 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s 2.1.5 [ 11553 ]
            Fix Version/s 2.1.4 [ 11452 ]
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes [ 10041 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.3 [ 10657 ]
            Fix Version/s 2.3 [ 10657 ]
            rajeshtaneja Rajesh Taneja made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester rajeshtaneja
            rajeshtaneja Rajesh Taneja made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 12/Jan/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12