Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-30033

no feedback in quiz review when grade is negative (using CBM)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Quiz
    • Labels:
    • Environment:
      any
    • Testing Instructions:
      Hide

      1. Create a quiz set to Deferred feedback with CBM behaviour, and some overall feedback, for example Feedback: Good; Grade boundary 50%; Feedback: Bad.
      2. Add one question, a T/F question with right-answer true.
      3. Attempt the quiz as a student. Give the answer false, and say that you are very sure you are right.
      4. Submit all and finish. You should get a score of -2 for the question, so the overall attempt score should also be negative.
      5. Verify that the Overall feedback is displayed at the top of the review page, and also on the view.php page when you click finish review.
      6. Log in as teacher, and verify that the overall feedback is also shown in the Responses report.

      Show
      1. Create a quiz set to Deferred feedback with CBM behaviour, and some overall feedback, for example Feedback: Good; Grade boundary 50%; Feedback: Bad. 2. Add one question, a T/F question with right-answer true. 3. Attempt the quiz as a student. Give the answer false, and say that you are very sure you are right. 4. Submit all and finish. You should get a score of -2 for the question, so the overall attempt score should also be negative. 5. Verify that the Overall feedback is displayed at the top of the review page, and also on the view.php page when you click finish review. 6. Log in as teacher, and verify that the overall feedback is also shown in the Responses report.
    • Workaround:
      Hide

      in /mod/quiz/locallib.php (line 346) I added the following hack:

      function quiz_feedback_for_grade($grade, $quiz, $context) {
      global $DB;

      if (is_null($grade))

      { return ''; }

      /*****

      • hack
      • set $grade to 0 if $grade is negative so that students with a negative grade do get feedback
        *****/
        $grade = max(0, $grade);
        /*****
      • end hack
        *****/

      This however, does not enable a specific feedback for negative grades

      Show
      in /mod/quiz/locallib.php (line 346) I added the following hack: function quiz_feedback_for_grade($grade, $quiz, $context) { global $DB; if (is_null($grade)) { return ''; } /***** hack set $grade to 0 if $grade is negative so that students with a negative grade do get feedback *****/ $grade = max(0, $grade); /***** end hack *****/ This however, does not enable a specific feedback for negative grades
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When using CBM it is possible to get a negative grade. As you can't define negative grade ranges for feedback no feedback is displayed at all when a student gets a negative grade.
      In my opinion this is a serious bug. Students that get a negative grade really, really, really need some explanation.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12