Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.14
    • Fix Version/s: 1.9.15
    • Component/s: Lesson
    • Labels:
      None
    • Testing Instructions:
      Hide

      Needs to be tested on PHP 4.

      Here are the original steps to reproduce:

      When creating a moodle lesson I get a blank page after I make my choice and click please check one answer. It is a multiple choice question.

      When i run debug this is the error I get

      Parse error: parse error, unexpected T_OBJECT_OPERATOR in /opt/moodle/html/mod/lesson/action/continue.php on line 418

      Show
      Needs to be tested on PHP 4. Here are the original steps to reproduce: When creating a moodle lesson I get a blank page after I make my choice and click please check one answer. It is a multiple choice question. When i run debug this is the error I get Parse error: parse error, unexpected T_OBJECT_OPERATOR in /opt/moodle/html/mod/lesson/action/continue.php on line 418
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE
    • Pull from Repository:

      Description

      http://moodle.org/mod/forum/discuss.php?d=186968

      Parse error: parse error, unexpected T_OBJECT_OPERATOR in /opt/moodle/html/mod/lesson/action/continue.php on line 418

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          Rossiani, I am pretty sure this is a correct fix. Please could you give it a quick look, and then submit it for integration. Thanks.

          Show
          Tim Hunt added a comment - Rossiani, I am pretty sure this is a correct fix. Please could you give it a quick look, and then submit it for integration. Thanks.
          Hide
          Rossiani Wijaya added a comment -

          Hi Tim,

          The code changes look fine.

          I haven't be able to test it with php4 but I don't think it will break the page.

          Submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Hi Tim, The code changes look fine. I haven't be able to test it with php4 but I don't think it will break the page. Submitting for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Tim Hunt added a comment -

          Rebased. And there is a comment in the forum thread that the fix worked for the original reporter.

          Show
          Tim Hunt added a comment - Rebased. And there is a comment in the forum thread that the fix worked for the original reporter.
          Hide
          Aparup Banerjee added a comment -

          Thank you, this has been integrated. Now for testing? (noted its been tested already)

          Show
          Aparup Banerjee added a comment - Thank you, this has been integrated. Now for testing? (noted its been tested already)
          Hide
          Jason Fowler added a comment -

          Test passed based on the test reported by a community member

          Show
          Jason Fowler added a comment - Test passed based on the test reported by a community member
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: