Moodle
  1. Moodle
  2. MDL-30059

Assignment Submission Notification Should Use Teacher's Timezone Rather Than Server Time

    Details

    • Testing Instructions:
      Hide

      As a teacher, change your timezone setting in your profile to something other than the server timezone.
      Create an assignment and elect to receive notifications of submissions.
      As a student, submit the assignment.
      Check your email account used for the teacher.
      You should have a notification of the submission and the submission time found in the body of the message should be relative to the teacher's timezone setting.

      Show
      As a teacher, change your timezone setting in your profile to something other than the server timezone. Create an assignment and elect to receive notifications of submissions. As a student, submit the assignment. Check your email account used for the teacher. You should have a notification of the submission and the submission time found in the body of the message should be relative to the teacher's timezone setting.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-30059-master
    • Rank:
      24690

      Description

      The assignment submission notifications that are sent to teachers include the submission time. The time is given according to the server's time settings. When the server is in a different timezone, the time in the email is wrong. The email notification should adjust the submission time to the teacher's timezone since the teacher is the recipient of the message.

        Activity

        Hide
        Chris Follin added a comment -

        Attaching patch that adjusts the submission time for the message body to the teacher's timezone.

        Show
        Chris Follin added a comment - Attaching patch that adjusts the submission time for the message body to the teacher's timezone.
        Hide
        Michael de Raadt added a comment -

        Thanks for putting this forward.

        I've added this to the STABLE backlog, but please keep pushing it towards integration.

        Show
        Michael de Raadt added a comment - Thanks for putting this forward. I've added this to the STABLE backlog, but please keep pushing it towards integration.
        Hide
        Jason Fowler added a comment -

        Hi Chris, the code looks fine. Do you have the ability to create a branch on github with this change for 2.0, 2.1 and 2.2dev?

        Show
        Jason Fowler added a comment - Hi Chris, the code looks fine. Do you have the ability to create a branch on github with this change for 2.0, 2.1 and 2.2dev?
        Hide
        Chris Follin added a comment -

        Jason, I don't think I do.

        Show
        Chris Follin added a comment - Jason, I don't think I do.
        Hide
        Mark Nielsen added a comment -

        Added github URLs

        Show
        Mark Nielsen added a comment - Added github URLs
        Hide
        Jason Fowler added a comment -

        Updated all relevant branches with changes

        Show
        Jason Fowler added a comment - Updated all relevant branches with changes
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated now.

        Jason just as a heads up I had to cherry-pick the 20 stable branch as you had included your fix for another issue in with that branch.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated now. Jason just as a heads up I had to cherry-pick the 20 stable branch as you had included your fix for another issue in with that branch. Cheers Sam
        Hide
        Rajesh Taneja added a comment -

        Notification now has time as per Teacher's timezone.
        Thanks for fixing this Chris

        Show
        Rajesh Taneja added a comment - Notification now has time as per Teacher's timezone. Thanks for fixing this Chris
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: