Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Grading methods
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Rank:
      24741

      Description

      Please help me to explain teachers/moderators that it is tricky to change the rubric after students have been graded.
      Also we need to try to get rid of words "teacher" and "student"

      $string['regrademessage1'] = 'You are about to save changes to the rubric that has already been used for grading. Please indicate whether your changes
                      are significant and students grades need to be reviewed.
                      If students already graded are marked for re-grading their
                      current grades remain in gradebook but the students will not see the rubric grading before teacher updates it.';
      $string['regradeoption0'] = 'do not mark to regrade';
      $string['regradeoption1'] = 'mark to regrade';
      
      $string['regrademessage5'] = 'You are about to save significant changes to the rubric that has already been used for grading. Please note that all students already graded will be marked for re-grading.
                      The
                      current grades remain in gradebook but the students will not see the rubric grading before teacher updates it.';
      
      $string['needregrademessage'] = 'Rubric definition was changed after this student had been graded. You must update the grade otherwise it will not be shown to student.';
      

        Activity

        Hide
        Helen Foster added a comment -

        Hi Marina, here are my suggestions. Hope I've understood things correctly - if not, please feel free to ignore any of my suggestions!

        $string['regrademessage1'] = 'Note: You are about to save changes to rubric which has already been used for grading. This will result in grades being marked for regrading. Students will not be able to view their grades until they are updated.';
        $string['regradeoption0'] = 'Do not mark for regrade';
        $string['regradeoption1'] = 'Mark for regrade';

        Sorry I didn't understand the difference between regrademessage1 and regrademessage5, so I've not suggested anything for regrademessage5.

        You'll notice that my suggestions do not use the word 'teacher', though I have used the word 'student' as it is the most common role to receive grades. If you prefer, 'student' could be replaced with 'user'.

        Show
        Helen Foster added a comment - Hi Marina, here are my suggestions. Hope I've understood things correctly - if not, please feel free to ignore any of my suggestions! $string ['regrademessage1'] = 'Note: You are about to save changes to rubric which has already been used for grading. This will result in grades being marked for regrading. Students will not be able to view their grades until they are updated.'; $string ['regradeoption0'] = 'Do not mark for regrade'; $string ['regradeoption1'] = 'Mark for regrade'; Sorry I didn't understand the difference between regrademessage1 and regrademessage5, so I've not suggested anything for regrademessage5. You'll notice that my suggestions do not use the word 'teacher', though I have used the word 'student' as it is the most common role to receive grades. If you prefer, 'student' could be replaced with 'user'.
        Hide
        Marina Glancy added a comment -

        Thanks Helen,
        the difference between regrademessage1 and regrademessage5 is that in case 1 the teacher is offered a choice - whether to mark for re-grade or not (it might have been just fixing a typo in some description)
        in case 5 teacher is not offered any choice because his changes are big and all student NEED to be re-graded, and this is just a notification

        Show
        Marina Glancy added a comment - Thanks Helen, the difference between regrademessage1 and regrademessage5 is that in case 1 the teacher is offered a choice - whether to mark for re-grade or not (it might have been just fixing a typo in some description) in case 5 teacher is not offered any choice because his changes are big and all student NEED to be re-graded, and this is just a notification
        Hide
        Marina Glancy added a comment -

        that's not exactly correct - if rubric is marked for regrade, students are still able to see their grades but they are not able to see the rubric

        Show
        Marina Glancy added a comment - that's not exactly correct - if rubric is marked for regrade, students are still able to see their grades but they are not able to see the rubric
        Hide
        Marina Glancy added a comment - - edited

        another string (from grading.php)

        Please note: the advanced grading form is not ready at the moment. Simple grading method will be used until the form has a valid status.

        Martin suggests: "The rubric form is currently being edited (draft mode). You can only use simple grading until the rubric is finalised."

        Show
        Marina Glancy added a comment - - edited another string (from grading.php) Please note: the advanced grading form is not ready at the moment. Simple grading method will be used until the form has a valid status. Martin suggests: "The rubric form is currently being edited (draft mode). You can only use simple grading until the rubric is finalised."
        Show
        Marina Glancy added a comment - More strings can be found at: https://github.com/mudrd8mz/moodle/compare/master...rubric#diff-9 and https://github.com/mudrd8mz/moodle/compare/master...rubric#diff-28 and below
        Hide
        Martin Dougiamas added a comment - - edited

        Suggested fixes: (old/new)

        $string['scorepostfix'] = ' points';
        $string['scorepostfix'] = '$a points'; // embed number in string, so order can be determined by language (Needs code change as well)

        $string['regrademessage1'] = 'You are about to save changes to the rubric that has already been used for grading. Please indicate whether your changes
        are significant and students grades need to be reviewed.
        If students already graded are marked for re-grading their
        current grades remain in gradebook but the students will not see the rubric grading before teacher updates it.';
        $string['regrademessage1'] = 'You are about to save changes to a rubric that has already been used for grading. Please indicate if existing grades need to be reviewed. If you set this then the rubric will be hidden from students until their item is regraded';

        $string['regrademessage5'] = 'You are about to save significant changes to the rubric that has already been used for grading. Please note that all students already graded will be marked for re-grading.
        The
        current grades remain in gradebook but the students will not see the rubric grading before teacher updates it.';
        $string['regrademessage5'] = 'You are about to save significant changes to a rubric that has already been used for grading. The gradebook value will be unchanged, but the rubric will be hidden from students until their item is regraded';

        $string['needregrademessage'] = 'Rubric definition was changed after this student had been graded. You must update the grade otherwise it will not be shown to student.';
        $string['needregrademessage'] = 'The rubric definition was changed after this student had been graded. The student can not see this rubric until you check the rubric and update the grade.';

        $string['restoredfromdraft'] = 'Please note: You did not submit the last attempt to grade this person. The grading is restored from draft. To cancel the changes press "Cancel" button below';
        $string['restoredfromdraft'] = 'NOTE: The last attempt to grade this person was not saved properly so draft grades have been restored. If you want to cancel these changes use the "Cancel" button below.';

        Show
        Martin Dougiamas added a comment - - edited Suggested fixes: (old/new) $string ['scorepostfix'] = ' points'; $string ['scorepostfix'] = '$a points'; // embed number in string, so order can be determined by language (Needs code change as well) $string ['regrademessage1'] = 'You are about to save changes to the rubric that has already been used for grading. Please indicate whether your changes are significant and students grades need to be reviewed. If students already graded are marked for re-grading their current grades remain in gradebook but the students will not see the rubric grading before teacher updates it.'; $string ['regrademessage1'] = 'You are about to save changes to a rubric that has already been used for grading. Please indicate if existing grades need to be reviewed. If you set this then the rubric will be hidden from students until their item is regraded'; $string ['regrademessage5'] = 'You are about to save significant changes to the rubric that has already been used for grading. Please note that all students already graded will be marked for re-grading. The current grades remain in gradebook but the students will not see the rubric grading before teacher updates it.'; $string ['regrademessage5'] = 'You are about to save significant changes to a rubric that has already been used for grading. The gradebook value will be unchanged, but the rubric will be hidden from students until their item is regraded'; $string ['needregrademessage'] = 'Rubric definition was changed after this student had been graded. You must update the grade otherwise it will not be shown to student.'; $string ['needregrademessage'] = 'The rubric definition was changed after this student had been graded. The student can not see this rubric until you check the rubric and update the grade.'; $string ['restoredfromdraft'] = 'Please note: You did not submit the last attempt to grade this person. The grading is restored from draft. To cancel the changes press "Cancel" button below'; $string ['restoredfromdraft'] = 'NOTE: The last attempt to grade this person was not saved properly so draft grades have been restored. If you want to cancel these changes use the "Cancel" button below.';
        Hide
        David Mudrak added a comment -

        Done. I just committed Martin's suggestions.

        Show
        David Mudrak added a comment - Done. I just committed Martin's suggestions.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: