[MDL-30121] Draft files included in zip file from "advanced uploading of files" activity - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.0, 2.2.4, 2.3.1, 2.4
Fix Version/s: 2.2.5, 2.3.2
Component/s: Assignment (2.2)
Labels:
- patch
- triaged

Affected Branches:
MOODLE_20_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Master Branch:
wip-mdl-30121
Pull Master Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-30121
Difficulty:
Easy
Testing Instructions:
Hide

As a teacher create "advanced uploading of files" activity

As a student1 upload file to assignment but don't send it for marking.

As a student2 upload file to assignment and send it for marking.

As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id= {activity_id}&download=zip)
# Make sure files uploaded by student 2 are only included in zip
# As student 1 send activity for marking
# As teacher view submission again and click "Download all assignments as a zip" (mod/assignment/submissions.php?id={activity_id}
&download=zip)

Make sure files from student 1 and student 2 are included in zip.
Show
As a teacher create "advanced uploading of files" activity As a student1 upload file to assignment but don't send it for marking. As a student2 upload file to assignment and send it for marking. As teacher view submission and click "Download all assignments as a zip" (mod/assignment/submissions.php?id= {activity_id}&download=zip) # Make sure files uploaded by student 2 are only included in zip # As student 1 send activity for marking # As teacher view submission again and click "Download all assignments as a zip" (mod/assignment/submissions.php?id={activity_id} &download=zip) Make sure files from student 1 and student 2 are included in zip.

Description

When you download zip file on "advanced uploading of files" activity, students drafts are in zip file too.

We think that teachers don't need to evaluate draft files...

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

exclude_drafts_from_zip_file.diff
2 kB
04/Nov/11 8:04 AM

Issue Links

caused a regression

MDL-35910 Download Assignment(2.2) files as zip

Closed

MDL-35912 Download all assignments as a zip is not working

Closed

has been marked as being related by

MDL-30144 "Download all as a zip" contains submissions from unenroled students

Closed

Activity

People

Assignee:: Rajesh Taneja

Reporter:: Julien Boulen

Peer reviewer:: Frédéric Massart

Integrator:: Eloy Lafuente (stronk7)

Tester:: Adrian Greeve

Participants:: Adrian Greeve, Eloy Lafuente (stronk7), Frédéric Massart, Julien Boulen, Michael de Raadt, Rajesh Taneja

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 04/Nov/11 8:00 AM

Updated:: 30/Sep/13 9:03 PM

Resolved:: 01/Sep/12 2:54 AM

Fix Release Date:: 10/Sep/12