Moodle
  1. Moodle
  2. MDL-30139

Enrol users - AJAX search requires Return key press, not obvious

    Details

    • Testing Instructions:
      Hide

      1. Go to the 'enrol users' page on a course. There must be at least one user on the system who is not enrolled on the course.
      2. Wait for page to load then click the 'Enrol users' button.
      3. Popup dialog appears showing users.
      4. Verify that the search box contains a button next to it. Check that you can search users by clicking on the button or pressing the enter key (which was the previous behaviour).

      Test this on all supported browsers to ensure the button does not break the pop-up layout.

      Show
      1. Go to the 'enrol users' page on a course. There must be at least one user on the system who is not enrolled on the course. 2. Wait for page to load then click the 'Enrol users' button. 3. Popup dialog appears showing users. 4. Verify that the search box contains a button next to it. Check that you can search users by clicking on the button or pressing the enter key (which was the previous behaviour). Test this on all supported browsers to ensure the button does not break the pop-up layout.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-30139_master
    • Rank:
      24803

      Description

      On my developer system when using the current master branch, if I go to the enrol users page and bring up the popup, typing in the search box has no immediate effect. For example, if there is only one user in the results, and I type some characters that are not in their name, the user does not disappear.

      If you press Return the search takes effect, but there isn't any indication that this is required and it confused both Tim and I for a bit...

      To solve this problem, I would suggest adding a 'Search' button next to the text box. This means novice users will click the button and expert users will understand that the Return key is also available.

        Activity

        Hide
        Michael de Raadt added a comment -

        Sounds like a good idea to me.

        Show
        Michael de Raadt added a comment - Sounds like a good idea to me.
        Hide
        Garret Gengler added a comment - - edited

        This fooled me (an experienced sysadmin and web developer), and all of our students assistants as well.

        No one could figure out how to get the search to work, except by entering search text, closing the popup, and re-opening it.

        We thought it was a bug until I found this tracker entry.

        Please fix this.

        Show
        Garret Gengler added a comment - - edited This fooled me (an experienced sysadmin and web developer), and all of our students assistants as well. No one could figure out how to get the search to work, except by entering search text, closing the popup, and re-opening it. We thought it was a bug until I found this tracker entry. Please fix this.
        Hide
        Michael de Raadt added a comment -

        I'm bumping this issue. It should be pretty easy.

        Show
        Michael de Raadt added a comment - I'm bumping this issue. It should be pretty easy.
        Hide
        Rossiani Wijaya added a comment -

        Hi Mark this looks great. +1 for integration.

        [y] Syntax
        [y] Output
        [y] Whitespace
        [-] Language
        [-] Databases
        [y] Testing
        [-] Security
        [-] Documentation
        [y] Git
        [y] Sanity check

        Show
        Rossiani Wijaya added a comment - Hi Mark this looks great. +1 for integration. [y] Syntax [y] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
        Hide
        Sam Hemelryk added a comment -

        Hoorah that this has been noticed and fixed. It has also now been integrated

        Show
        Sam Hemelryk added a comment - Hoorah that this has been noticed and fixed. It has also now been integrated
        Hide
        Adrian Greeve added a comment -

        Tested on Firefox, IE9, Chrome and Safari.
        The search button doesn't seem to break in those browsers.
        All works as expected.
        Test passed.

        Show
        Adrian Greeve added a comment - Tested on Firefox, IE9, Chrome and Safari. The search button doesn't seem to break in those browsers. All works as expected. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Y E S !

        Closing as fixed, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Y E S ! Closing as fixed, many thanks!

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: